EWPP-3349: Fix failing tests for 10.1.

openeuropa · Aug 31, 2023 · 6628545 · 6628545
1 parent 8158621
commit 6628545
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 1 deletion.
diff --git a/...es/oe_theme_content_event/tests/src/FunctionalJavascript/InfoDisclosureExtraFieldTest.php b/...es/oe_theme_content_event/tests/src/FunctionalJavascript/InfoDisclosureExtraFieldTest.php
@@ -18,6 +18,11 @@
  */
 class InfoDisclosureExtraFieldTest extends WebDriverTestBase {
 
+  /**
+   * {@inheritdoc}
+   */
+  protected $failOnJavascriptConsoleErrors = FALSE;
+
   /**
    * {@inheritdoc}
    */

diff --git a/modules/oe_theme_helper/tests/src/FunctionalJavascript/InPageNavigationLibraryTest.php b/modules/oe_theme_helper/tests/src/FunctionalJavascript/InPageNavigationLibraryTest.php
@@ -16,6 +16,11 @@
  */
 class InPageNavigationLibraryTest extends WebDriverTestBase {
 
+  /**
+   * {@inheritdoc}
+   */
+  protected $failOnJavascriptConsoleErrors = FALSE;
+
   /**
    * {@inheritdoc}
    */

diff --git a/modules/oe_theme_helper/tests/src/FunctionalJavascript/InPageNavigationParagraphTest.php b/modules/oe_theme_helper/tests/src/FunctionalJavascript/InPageNavigationParagraphTest.php
@@ -17,6 +17,11 @@
  */
 class InPageNavigationParagraphTest extends WebDriverTestBase {
 
+  /**
+   * {@inheritdoc}
+   */
+  protected $failOnJavascriptConsoleErrors = FALSE;
+
   /**
    * {@inheritdoc}
    */

diff --git a/modules/oe_theme_helper/tests/src/FunctionalJavascript/WysiwygTableTest.php b/modules/oe_theme_helper/tests/src/FunctionalJavascript/WysiwygTableTest.php
@@ -22,6 +22,11 @@ class WysiwygTableTest extends WebDriverTestBase {
 
   use CKEditorTestTrait;
 
+  /**
+   * {@inheritdoc}
+   */
+  protected $failOnJavascriptConsoleErrors = FALSE;
+
   /**
    * {@inheritdoc}
    */

diff --git a/modules/oe_theme_helper/tests/src/Kernel/InPageNavigationBlockTest.php b/modules/oe_theme_helper/tests/src/Kernel/InPageNavigationBlockTest.php
@@ -16,6 +16,11 @@
  */
 class InPageNavigationBlockTest extends AbstractKernelTestBase {
 
+  /**
+   * {@inheritdoc}
+   */
+  protected $failOnJavascriptConsoleErrors = FALSE;
+
   /**
    * Tests the block markup.
    */

diff --git a/modules/oe_theme_helper/tests/src/Kernel/TwigExtensionTest.php b/modules/oe_theme_helper/tests/src/Kernel/TwigExtensionTest.php
@@ -70,6 +70,8 @@ public function testSmartTrimFilter(array $variables, array $assertions, array $
    *   An array of test data arrays with assertions.
    */
   public function smartTrimFilterDataProvider(): array {
+    $drupal_version = (float) substr(\Drupal::VERSION, 0, 4);
+
     return [
       'Trim a string' => [
         'variables' => [
@@ -121,7 +123,10 @@ public function smartTrimFilterDataProvider(): array {
         ],
         'assertions' => [
           'contains' => [
-            "&lt;script&gt;\n&lt;!--//--&gt;&lt;![CDATA[// &gt;&lt;!--\ndocum...\n//--&gt;&lt;!]]&gt;\n&lt;/script&gt;",
+            // https://www.drupal.org/project/drupal/issues/3259255
+            $drupal_version < 10.1 ?
+            "&lt;script&gt;\n&lt;!--//--&gt;&lt;![CDATA[// &gt;&lt;!--\ndocum...\n//--&gt;&lt;!]]&gt;\n&lt;/script&gt;" :
+            "&lt;script&gt;\n//&lt;![CDATA[\ndocum...\n//]]&gt;\n&lt;/script&gt;",
           ],
         ],
       ],