EWPP-4071: Do not escape the url when generating it in the FileValueO…

…bject.
openeuropa · May 23, 2024 · 0e58450 · 0e58450
1 parent da52b0a
commit 0e58450
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/ValueObject/FileValueObject.php b/src/ValueObject/FileValueObject.php
@@ -157,7 +157,7 @@ public static function fromFileLink(FileLinkItem $link): ValueObjectInterface {
    *   Property value.
    */
   public function getUrl(): string {
-    return UrlHelper::filterBadProtocol($this->url);
+    return UrlHelper::stripDangerousProtocols($this->url);
   }
 
   /**

diff --git a/tests/src/Unit/ValueObject/FileValueObjectTest.php b/tests/src/Unit/ValueObject/FileValueObjectTest.php
@@ -40,6 +40,11 @@ public function testFromArray() {
     $data['language_code'] = 'fr';
     $file = FileValueObject::fromArray($data);
     $this->assertEquals('fr', $file->getLanguageCode());
+
+    // Assert that urls are not escaped when returned by the object.
+    $data['url'] ='http://example.com/test.pdf?param1=a&param2=b';
+    $file = FileValueObject::fromArray($data);
+    $this->assertEquals('http://example.com/test.pdf?param1=a&param2=b', $file->getUrl());
   }
 
 }