OEL-3058: Check strings before deletion. #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brummbar
requested changes
Jun 19, 2024
oe_corporate_blocks.post_update.php
Outdated
Comment on lines
341
to
345
| $strings = [ | ||
| ['source' => 'Search all EU institutions and bodies'], | ||
| ['source' => 'EU institutions and bodies'], | ||
| ['source' => 'https://european-union.europa.eu/institutions-law-budget/institutions-and-bodies/search-all-eu-institutions-and-bodies_en'], | ||
| ]; |
There was a problem hiding this comment.
The 'source' key can be dropped and we keep just the value.
There was a problem hiding this comment.
Not if we use StringDatabaseStorage, the keys of the arrays must match fields in the db table (lid, source, context, version), and it must be an array of conditions.
There was a problem hiding this comment.
Suggested change
| $strings = [ | |
| ['source' => 'Search all EU institutions and bodies'], | |
| ['source' => 'EU institutions and bodies'], | |
| ['source' => 'https://european-union.europa.eu/institutions-law-budget/institutions-and-bodies/search-all-eu-institutions-and-bodies_en'], | |
| ]; | |
| $strings = [ | |
| 'Search all EU institutions and bodies', | |
| 'EU institutions and bodies', | |
| 'https://european-union.europa.eu/institutions-law-budget/institutions-and-bodies/search-all-eu-institutions-and-bodies_en', | |
| ]; |
and then
$string = $storage->findString(['source' => $string]);
There was a problem hiding this comment.
Let's also take the chance to rename $strings to $sources.
There was a problem hiding this comment.
clear enough, I misunderstood the first time
brummbar
approved these changes
Jun 24, 2024
nagyad
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OEL-3058
Description
Websites other than ewpp may not have the strings, so when the local storage tries to fetch them the result will be null.
reported also in #158
Change log