Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

EWPP-1850: Using the proper langcode for the video iframe URL. #70

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

upchuk
Copy link
Contributor

@upchuk upchuk commented Jan 27, 2022

No description provided.

@upchuk upchuk changed the title EWPP-1850: Testing that the video iframe URL gets the correct language code. EWPP-1850: Using the proper langcode for the video iframe URL. Jan 28, 2022
Copy link
Member

@nagyad nagyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. phpcs error needs to be addressed.
  2. EWCMS PR is missing and tests.

yenyasinn
yenyasinn previously approved these changes Feb 1, 2022
nagyad
nagyad previously approved these changes Feb 1, 2022
@upchuk upchuk dismissed stale reviews from nagyad and yenyasinn via bc6c951 February 8, 2022 14:01
@upchuk upchuk merged commit b170c26 into 8.x-1.x Feb 8, 2022
@upchuk upchuk deleted the EWPP-1850 branch February 8, 2022 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants