Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

OPENEUROPA-1844: Fixing AV Portal stream wrapper #19

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Conversation

upchuk
Copy link
Contributor

@upchuk upchuk commented Apr 24, 2019

OPENEUROPA-1844

Description

The AV Portal stream wrapper used for generating image styles based in AV Portal photos did not work correctly for all photos. Some photos were fine while others were not. The issue was traced to the stream wrapper.

The solution (and improvement) is to use a contrib module called Remote Stream Wrapper which provides a good basis for extending our stream wrapper from. This uses Guzzle streams which does a lot of the heavy lifting. However, the module also makes an assumption we don't want: it prevents image styles from being generated for images that are not somehow managed. Which in our case is not ok because the AV portal photos are not treated as managed files. So I also made an issue and patch to make this assumption extensible for child stream wrappers: https://www.drupal.org/project/remote_stream_wrapper/issues/3050183

Copy link
Member

@hernani hernani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link
Member

@sergepavle sergepavle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It works good. But better also to add in Kernel tests image styles coverage.

@upchuk upchuk merged commit 365bc89 into 8.x-1.x Apr 24, 2019
@upchuk upchuk deleted the OPENEUROPA-1844 branch April 24, 2019 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants