This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
OPENEUROPA-1844: Fixing AV Portal stream wrapper #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-1844
Description
The AV Portal stream wrapper used for generating image styles based in AV Portal photos did not work correctly for all photos. Some photos were fine while others were not. The issue was traced to the stream wrapper.
The solution (and improvement) is to use a contrib module called Remote Stream Wrapper which provides a good basis for extending our stream wrapper from. This uses Guzzle streams which does a lot of the heavy lifting. However, the module also makes an assumption we don't want: it prevents image styles from being generated for images that are not somehow managed. Which in our case is not ok because the AV portal photos are not treated as managed files. So I also made an issue and patch to make this assumption extensible for child stream wrappers: https://www.drupal.org/project/remote_stream_wrapper/issues/3050183