Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

ci: rearrange pipeline by logic #9970

Merged
merged 2 commits into from
Nov 27, 2018
Merged

ci: rearrange pipeline by logic #9970

merged 2 commits into from
Nov 27, 2018

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Nov 27, 2018

  • audit job is renamed and moved to test stage (is cheap to run and should never fail)
  • docs job is renamed and moved to the publish stage (where it belongs)
  • all jobs in the optional stage are allowed to fail

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). B1-patch-beta 🕷🕷 M1-ci 🙉 Continuous integration. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Nov 27, 2018
@ordian
Copy link
Collaborator

ordian commented Nov 27, 2018

Note, that cargo audit fails when a vulnerability was discovered in a crate we're using. It may happen at any point in time. It shouldn't block merging a PR, that has changes unrelated to this failure (even if CI is failing), unless it introduces a dependency with a vulnerability, that is not yet fixed.

gabreal
gabreal approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@gabreal gabreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@gabreal
Copy link
Contributor

gabreal commented Nov 27, 2018

It would be nice to be able to authorize certain security vulnerabilities somehow - if audits are allowed to fail here they are likely to become overseen.

@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Nov 27, 2018
@5chdn
Copy link
Contributor Author

5chdn commented Nov 27, 2018 •
edited
Loading

@ordian I see, but it's not required - so it's not blocking the PR to be merged. It just shows a big red X once something is discovered, wherever it may come from.

@5chdn 5chdn added this to the 2.3 milestone Nov 27, 2018
@5chdn 5chdn requested a review from lovelaced November 27, 2018 11:12
@5chdn 5chdn merged commit c584221 into master Nov 27, 2018
@5chdn 5chdn deleted the a5-gitlab-optional branch November 27, 2018 11:51
@5chdn 5chdn mentioned this pull request Nov 27, 2018
Merged
12 tasks
5chdn added a commit that referenced this pull request Nov 27, 2018
@5chdn
ci: rearrange pipeline by logic (#9970)
1ba2cb4 
* ci: rearrange pipeline by logic

* ci: rename docs script
@5chdn 5chdn mentioned this pull request Nov 27, 2018
Merged
10 tasks
5chdn added a commit that referenced this pull request Nov 27, 2018
@5chdn
ci: rearrange pipeline by logic (#9970)
f74a9d5 
* ci: rearrange pipeline by logic

* ci: rename docs script
5chdn added a commit that referenced this pull request Nov 28, 2018
@5chdn
Backports for stable 2.1.7 (#9975)
126208c 
* version: bump stable to 2.1.7

* Adjust requests costs for light client (#9925)

* PIP Table Cost relative to average peers instead of max peers

* Add tracing in PIP new_cost_table

* Update stat peer_count

* Use number of leeching peers for Light serve costs

* Fix test::light_params_load_share_depends_on_max_peers (wrong type)

* Remove (now) useless test

* Remove `load_share` from LightParams.Config
Prevent div. by 0

* Add LEECHER_COUNT_FACTOR

* PR Grumble: u64 to u32 for f64 casting

* Prevent u32 overflow for avg_peer_count

* Add tests for LightSync::Statistics

* Fix empty steps (#9939)

* Don't send empty step twice or empty step then block.

* Perform basic validation of locally sealed blocks.

* Don't include empty step twice.

* prevent silent errors in daemon mode, closes #9367 (#9946)

* Fix light client informant while syncing (#9932)

* Add `is_idle` to LightSync to check importing status

* Use SyncStateWrapper to make sure is_idle gets updates

* Update is_major_import to use verified queue size as well

* Add comment for `is_idle`

* Add Debug to `SyncStateWrapper`

* `fn get` -> `fn into_inner`

*  ci: rearrange pipeline by logic (#9970)

* ci: rearrange pipeline by logic

* ci: rename docs script

* Add readiness check for docker container (#9804)

* Update Dockerfile

Since parity is built for "mission critical use", I thought other operators may see the need for this.

Adding the `curl` and `jq` commands allows for an extremely simple health check to be usable in container orchestrators.

For example. Here is a health check for a parity docker container running in Kubernetes.

This can be setup as a readiness Probe that would prevent clustered nodes that aren't ready from serving traffic.

```bash
#!/bin/bash

ETH_SYNCING=$(curl -X POST --data '{"jsonrpc":"2.0","method":"eth_syncing","params":[],"id":1}' http://localhost:8545 -H 'Content-Type: application/json')
RESULT=$(echo "$ETH_SYNCING | jq -r .result)

if [ "$RESULT" == "false" ]; then
  echo "Parity is ready to start accepting traffic"
  exit 0
else
  echo "Parity is still syncing the blockchain"
  exit 1
fi
```

* add sync check script

* Fix docker script (#9854)


* Dockerfile: change source path of the newly added check_sync.sh (#9869)

* Do not use the home directory as the working dir in docker (#9834)

* Do not create a home directory.

* Re-add -m flag

* fix docker build (#9971)

* bump smallvec to 0.6 in ethcore-light, ethstore and whisper (#9588)

* bump smallvec to 0.6 in ethcore-light, ethstore and whisper

* bump transaction-pool

* Fix test.

* patch cargo to use tokio-proto from git repo

this makes sure we no longer depend on smallvec 0.2.1 which is
affected by servo/rust-smallvec#96

* use patched version of untrusted 0.5.1

* ci: allow audit to fail
5chdn added a commit that referenced this pull request Nov 29, 2018
@5chdn
Backports for beta 2.2.2 (#9976)
78ceec6 
* version: bump beta to 2.2.2

* Add experimental RPCs flag (#9928)

* WiP

* Enable experimental RPCs.

* Keep existing blocks when restoring a Snapshot (#8643)

* Rename db_restore => client

* First step: make it compile!

* Second step: working implementation!

* Refactoring

* Fix tests

* PR Grumbles

* PR Grumbles WIP

* Migrate ancient blocks interating backward

* Early return in block migration if snapshot is aborted

* Remove RwLock getter (PR Grumble I)

* Remove dependency on `Client`: only used Traits

* Add test for recovering aborted snapshot recovery

* Add test for migrating old blocks

* Fix build

* PR Grumble I

* PR Grumble II

* PR Grumble III

* PR Grumble IV

* PR Grumble V

* PR Grumble VI

* Fix one test

* Fix test

* PR Grumble

* PR Grumbles

* PR Grumbles II

* Fix tests

* Release RwLock earlier

* Revert Cargo.lock

* Update _update ancient block_ logic: set local in `commit`

* Update typo in ethcore/src/snapshot/service.rs

Co-Authored-By: ngotchac <ngotchac@gmail.com>

* Adjust requests costs for light client (#9925)

* PIP Table Cost relative to average peers instead of max peers

* Add tracing in PIP new_cost_table

* Update stat peer_count

* Use number of leeching peers for Light serve costs

* Fix test::light_params_load_share_depends_on_max_peers (wrong type)

* Remove (now) useless test

* Remove `load_share` from LightParams.Config
Prevent div. by 0

* Add LEECHER_COUNT_FACTOR

* PR Grumble: u64 to u32 for f64 casting

* Prevent u32 overflow for avg_peer_count

* Add tests for LightSync::Statistics

* Fix empty steps (#9939)

* Don't send empty step twice or empty step then block.

* Perform basic validation of locally sealed blocks.

* Don't include empty step twice.

* prevent silent errors in daemon mode, closes #9367 (#9946)

* Fix a deadlock (#9952)

* Update informant:
  - decimal in Mgas/s
  - print every 5s (not randomly between 5s and 10s)

* Fix dead-lock in `blockchain.rs`

* Update locks ordering

* Fix light client informant while syncing (#9932)

* Add `is_idle` to LightSync to check importing status

* Use SyncStateWrapper to make sure is_idle gets updates

* Update is_major_import to use verified queue size as well

* Add comment for `is_idle`

* Add Debug to `SyncStateWrapper`

* `fn get` -> `fn into_inner`

*  ci: rearrange pipeline by logic (#9970)

* ci: rearrange pipeline by logic

* ci: rename docs script

* fix docker build (#9971)

* Deny unknown fields for chainspec (#9972)

* Add deny_unknown_fields to chainspec

* Add tests and fix existing one

* Remove serde_ignored dependency for chainspec

* Fix rpc test eth chain spec

* Fix starting_nonce_test spec

* Improve block and transaction propagation (#9954)

* Refactor sync to add priority tasks.

* Send priority tasks notifications.

* Propagate blocks, optimize transactions.

* Implement transaction propagation. Use sync_channel.

* Tone down info.

* Prevent deadlock by not waiting forever for sync lock.

* Fix lock order.

* Don't use sync_channel to prevent deadlocks.

* Fix tests.

* Fix unstable peers and slowness in sync (#9967)

* Don't sync all peers after each response

* Update formating

* Fix tests: add `continue_sync` to `Sync_step`

* Update ethcore/sync/src/chain/mod.rs

Co-Authored-By: ngotchac <ngotchac@gmail.com>

* fix rpc middlewares

* fix Cargo.lock

* json: resolve merge in spec

* rpc: fix starting_nonce_test

* ci: allow nightl job to fail
niklasad1 pushed a commit that referenced this pull request Dec 16, 2018
@5chdn @niklasad1
ci: rearrange pipeline by logic (#9970)
e43df87 
* ci: rearrange pipeline by logic

* ci: rename docs script
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabreal gabreal gabreal approved these changes

@sorpaas sorpaas sorpaas approved these changes

@TriplEight TriplEight Awaiting requested review from TriplEight

@lovelaced lovelaced Awaiting requested review from lovelaced

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M1-ci 🙉 Continuous integration.
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@5chdn @ordian @gabreal @sorpaas