This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Support millisecond timestamp for instant seal engine #9469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
added
A0-pleasereview 🤓
ordian
reviewed
Sep 4, 2018
json/src/spec/instant_seal.rs
Outdated
| pub struct InstantSealParams { | ||
| /// Whether to enable millisecond timestamp. | ||
| #[serde(rename="millisecondTimestamp")] | ||
| pub millisecond_timestamp: Option<bool>, |
There was a problem hiding this comment.
Maybe use #[serde(default)] and make it a bool? Option<bool> seems like an overkill.
andresilva
suggested changes
Sep 5, 2018
There was a problem hiding this comment.
LGTM. Just think we can change the type in the json spec as @ordian mentioned.
5chdn
added
A5-grumble 🔥
sorpaas
added
A0-pleasereview 🤓
andresilva
approved these changes
Sep 6, 2018
ordian
approved these changes
Sep 6, 2018
ordian
added
A8-looksgood 🦄
|
Can we add this to the wiki please @sorpaas ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9468
In instant seal engine, one can set the
millisecondTimestampconfig to enable millisecond timestamp resolution. I didn't add nanosecond support because that overflowsu64.