Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add Callisto support #9445

Closed
wants to merge 1 commit into from
Closed

Add Callisto support #9445

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 31, 2018

fixes #9283

Callisto info

Website: https://callisto.network
Whitepaper: https://whitepaper.callisto.network

Chain

Testnet -> galilei
Mainnet -> callisto

The code has little changes to run Callisto with Treasury and Stake funds.

@parity-cla-bot
Copy link

It looks like @akx20000a signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@ghost
Copy link
Author

ghost commented Aug 31, 2018 •
edited by ghost
Loading

Sync is working as intended

user@ubuntu:~/rust-callisto$ ./target/release/parity --chain=callisto --no-warp
2018-08-31 12:32:05  Starting Parity-Ethereum/v2.1.0-nightly-ec7983c-20180227/x86_64-linux-gnu/rustc1.28.0
2018-08-31 12:32:05  Keys path /home/user/.local/share/io.parity.ethereum/keys/Callisto
2018-08-31 12:32:05  DB path /home/user/.local/share/io.parity.ethereum/chains/Callisto/db/1b2904ad30128c93
2018-08-31 12:32:05  State DB configuration: fast
2018-08-31 12:32:05  Operating mode: active
2018-08-31 12:32:05  Configured for Callisto using Ethash engine
2018-08-31 12:32:10  Public node URL: enode://9e3bf5ed85d462a45f604f3e4d752f54ab549c36bc505b812c504fe48d8ff54679dc083f6c714a8e5c82c91cc7bf6f2b1ca0251d6f6423447b99c71fd45c6b8d@10.0.2.15:30303
2018-08-31 12:32:15  Syncing     #214 0xb3e7…4e18    21.43 blk/s 11096.2 tx/s  233 Mgas/s    104+    1 Qed      #321    5/25 peers   0 bytes chain 70 MiB db 40 MiB queue 1 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2018-08-31 12:32:25  Syncing     #451 0xd8bf…7b32    23.77 blk/s 13799.8 tx/s  289 Mgas/s     84+    0 Qed      #537    5/25 peers   0 bytes chain 121 MiB db 33 MiB queue 35 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2018-08-31 12:32:35  Syncing     #643 0xda80…a25c    19.25 blk/s 12407.0 tx/s  260 Mgas/s    190+    0 Qed      #843    5/25 peers   0 bytes chain 120 MiB db 76 MiB queue 31 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2018-08-31 12:32:45  Syncing     #824 0xcd35…a3a4    18.08 blk/s 12756.3 tx/s  267 Mgas/s    146+    0 Qed      #972    5/25 peers   0 bytes chain 119 MiB db 59 MiB queue 31 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2018-08-31 12:32:55  Syncing     #983 0xcea1…28b5    16.04 blk/s 12293.7 tx/s  258 Mgas/s    112+    1 Qed     #1099    5/25 peers   0 bytes chain 123 MiB db 46 MiB queue 28 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2018-08-31 12:33:05  Syncing    #1128 0xb28b…961d    14.55 blk/s 11846.3 tx/s  248 Mgas/s    278+    1 Qed     #1417    5/25 peers   5 MiB chain 125 MiB db 104 MiB queue 22 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2018-08-31 12:33:15  Syncing    #1304 0xb445…c7c6    17.69 blk/s 12707.3 tx/s  266 Mgas/s    110+    0 Qed     #1417    5/25 peers   0 bytes chain 125 MiB db 45 MiB queue 22 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2018-08-31 12:33:25  Syncing    #1437 0x4587…1f02    13.23 blk/s 11856.0 tx/s  248 Mgas/s     78+    1 Qed     #1517    5/25 peers   9 MiB chain 124 MiB db 33 MiB queue 69 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2018-08-31 12:33:36  Syncing    #1559 0x2096…e680    12.32 blk/s 11714.0 tx/s  245 Mgas/s     62+    0 Qed     #9540    5/25 peers   4 KiB chain 124 MiB db 32 MiB queue 14 MiB sync  RPC:  0 conn,    0 req/s,    0 µs
2018-08-31 12:33:45  Syncing    #1677 0x6d66…c5b0    13.05 blk/s 13321.9 tx/s  279 Mgas/s   9367+    1 Qed    #11048    5/25 peers   0 bytes chain 123 MiB db 34 MiB queue 13 MiB sync  RPC:  0 conn,    0 req/s,    0 µs

Feel free to ask us anything about callisto

cc @5chdn @sorpaas @Tbaut

@ghost
Copy link
Author

ghost commented Aug 31, 2018

ps) we will not use reward contract this time, but thanks for the suggestion @sorpaas !

@sorpaas
Copy link
Collaborator

sorpaas commented Aug 31, 2018

@akx20000a Please understand that we're really suffering maintainability issues on the on_close_block fn, as it already has many chain-specific reward parameters. We're really hesitant to add any more chain-specific code in that fn. That's the reason for introducing blockRewardContractCode. This is also to make it easy for other chains to add Parity Ethereum support, because it will certainly be faster for us to review and merge your changes.

If you really think your chain should directly use on_close_block fn but not the blockRewardContractCode, I think you would need to provide strong justifications about why you need that (for example, what you want to do that cannot be implemented with blockRewardContractCode). Otherwise we may just kindly ask you to use block reward contract because of the reasons provided above.

@sorpaas sorpaas added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. M2-config 📂 Chain specifications and node configurations. labels Aug 31, 2018
@sorpaas sorpaas added this to the 2.1 milestone Aug 31, 2018
@ghost
Copy link
Author

ghost commented Aug 31, 2018

@sorpaas Cause we don't want our block rewards to be frozen maybe?

As I said before, we will consider implementation in contract when there is a working example for chain ( for ex musicoin )

Otherwise we will prefer implementing on on_close_block which is a direct consensus to node layer.

Also I believe checking them through verification will help during sync.

Thanks for your opinion.

5chdn
5chdn suggested changes Aug 31, 2018
View reviewed changes
ethcore/res/ethereum/callisto.json Outdated
@@ -0,0 +1,83 @@
{
"name": "Callisto",
"dataDir": "Callisto",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this smal cap callisto?

ethcore/res/ethereum/callisto.json Outdated
"durationLimit": "0x0d",
"blockReward": "0x16c4abbebea0100000",
"homesteadTransition": "0x0",
"callistoTransition": "0x0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

callistoTransition does nothing. please remove it from code or clarify what that achieves.

ethcore/res/ethereum/callisto.json Outdated
"0000000000000000000000000000000000000007": { "balance": "1", "builtin": { "name": "alt_bn128_mul", "activate_at": 20, "pricing": { "linear": { "base": 40000, "word": 0 } } } },
"0000000000000000000000000000000000000008": { "balance": "1", "builtin": { "name": "alt_bn128_pairing", "activate_at": 20, "pricing": { "alt_bn128_pairing": { "base": 100000, "pair": 80000 } } } },
"0x183394f52b2c8c034835edba3bcececa6f60b5a8": {
"balance": "100491852286952719463755404"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@5chdn 5chdn added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Aug 31, 2018
@ghost
Copy link
Author

ghost commented Aug 31, 2018

@5chdn Fixed, thanks for the review 👍

@5chdn
Copy link
Contributor

5chdn commented Sep 6, 2018

Closing as author deleted Github.

@5chdn 5chdn closed this Sep 6, 2018
@yograterol yograterol mentioned this pull request Sep 12, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Milestone
2.1 Whatever
Development

Successfully merging this pull request may close these issues.
3 participants
@parity-cla-bot @sorpaas @5chdn