Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

update Dockerfile for hub #9162

Closed
wants to merge 2 commits into from
Closed

update Dockerfile for hub #9162

wants to merge 2 commits into from

Conversation

General-Beck
Copy link
Contributor

update to Ubuntu Xenial 16.04

@General-Beck
update Dockerfile for hub
5a46d91 
update to Ubuntu Xenial 16.04
fix cmake version
@General-Beck General-Beck added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M1-ci 🙉 Continuous integration. labels Jul 18, 2018
@General-Beck General-Beck requested review from andresilva and 5chdn July 18, 2018 10:59
ghost
ghost suggested changes Jul 18, 2018
View reviewed changes
docker/hub/Dockerfile Outdated
@@ -52,6 +51,7 @@ cd /build&&git clone https://github.com/paritytech/parity && \
# add-apt-repository
software-properties-common \
make \
cmake \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typo here

@5chdn 5chdn added this to the 2.1 milestone Jul 18, 2018
@5chdn 5chdn added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 18, 2018
5chdn
5chdn approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@5chdn 5chdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use spaces not tabs here. Otherwise good.

@parity-cla-bot
Copy link

It looks like @General-Beck signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

andresilva
andresilva approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pushed a fix for the indentation.

@andresilva andresilva added A8-looksgood 🦄 Pull request is reviewed well. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Jul 19, 2018
@andresilva
Copy link
Contributor

The build for this PR has run and passed (https://gitlab.parity.io/parity/parity/-/jobs/92370). The PR status is not being updated and I can't force the merge.

@ddorgan ddorgan closed this Jul 19, 2018
@ddorgan ddorgan reopened this Jul 19, 2018
@ddorgan ddorgan closed this Jul 19, 2018
@ddorgan ddorgan reopened this Jul 19, 2018
@andresilva andresilva closed this Jul 19, 2018
@andresilva andresilva mentioned this pull request Jul 19, 2018
Merged
@devops-parity devops-parity deleted the a5-ci-docker branch July 20, 2018 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@5chdn 5chdn 5chdn approved these changes

@andresilva andresilva andresilva approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M1-ci 🙉 Continuous integration.
Projects
None yet
Milestone
2.1 Whatever
Development

Successfully merging this pull request may close these issues.
5 participants
@General-Beck @parity-cla-bot @andresilva @5chdn @ddorgan