Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Ensure jsonrpc threading settings are sane #11267

Merged
merged 11 commits into from
Nov 18, 2019
Merged

Ensure jsonrpc threading settings are sane #11267

merged 11 commits into from
Nov 18, 2019

Commits on Nov 15, 2019

  1. Ensure jsonrpc threading settings are sane 

    Starting with `jsonrpc` v14, the "server threads" setting is more important than before and the current default of 1 means the https server is effectively single-threaded. This PR proposes a new default of 4 (and ensures that crazy settings like e.g. `0` are bumped to at least `1`).

Also included: some docs, tests and cosmetics.
    @dvdplm
    dvdplm committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    9360174 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. Update parity/rpc.rs 

    Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
    @dvdplm @tomusdrw
    dvdplm and tomusdrw committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    d94e313 View commit details
    Browse the repository at this point in the history

  2. Update parity/rpc.rs 

    Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
    @dvdplm @tomusdrw
    dvdplm and tomusdrw committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    5fd5cb0 View commit details
    Browse the repository at this point in the history

  3. Remove (i.e. deprecate) --jsonrpc-threads command line option

    @dvdplm
    dvdplm committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    dc0d349 View commit details
    Browse the repository at this point in the history

  4. Call numbers NUM

    @dvdplm
    dvdplm committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    5b74e46 View commit details
    Browse the repository at this point in the history

  5. Don't show a default for --jsonrpc-threads (deprecated)

    @dvdplm
    dvdplm committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    a97a484 View commit details
    Browse the repository at this point in the history

  6. Show deprecation warning when using --jsonrpc-threads or `processin… 

    …g_threads`
    @dvdplm
    dvdplm committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    91911fc View commit details
    Browse the repository at this point in the history

  7. Update parity/deprecated.rs 

    Co-Authored-By: Niklas Adolfsson <niklasadolfsson1@gmail.com>
    @dvdplm @niklasad1
    dvdplm and niklasad1 committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    fad3bd1 View commit details
    Browse the repository at this point in the history

  8. Fix test

    @dvdplm
    dvdplm committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    cf63b08 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'dp/fix/better-default-jsonrpc-threading-settings' of gi… 

    …thub.com:paritytech/parity-ethereum into dp/fix/better-default-jsonrpc-threading-settings

* 'dp/fix/better-default-jsonrpc-threading-settings' of github.com:paritytech/parity-ethereum:
  Update parity/deprecated.rs
    @dvdplm
    dvdplm committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    946763c View commit details
    Browse the repository at this point in the history

  10. Fix tests for real

    @dvdplm
    dvdplm committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    c49a057 View commit details
    Browse the repository at this point in the history