This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix registrar errors early in the chain #11257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
changed the title
dvdplm
added
A2-insubstantial 👶
debris
approved these changes
Nov 15, 2019
debris
added
A8-looksgood 🦄
tomusdrw
approved these changes
Nov 15, 2019
|
Yeah, it's most likely missing contract code if it returns an empty bytes vector. |
niklasad1
deleted the
dp/fix/spurious-registrar-errors-early-in-the-chain
branch
dvdplm
added a commit
that referenced
this pull request
Nov 20, 2019
* master: Clarify what first_block `None` means (#11269) removed redundant VMType enum with one variant (#11266) Ensure jsonrpc threading settings are sane (#11267) Return Ok(None) when the registrar contract returns empty slice (#11257) Add a benchmark for snapshot::account::to_fat_rlps() (#11185) Fix misc compile warnings (#11258) simplify verification (#11249)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR the registrar contract was overhauled. After it, syncing from the beginning of the chain spews out a ton of errors like this:
It looks a bit nasty but I don't think it's critical. At some point in the chain the problem goes away (not sure exactly were tbh but sometime after ~3M blocks).
The error message comes from
ethabiand what it really means is we passed in an empty slice of bytes to thedecode_output(). Further up in the chain we get0x0000000000000000000000000000000000000000back and so we hit theaddress.is_zero()case and all is good (I have a DB synced to ~4.4M where I see this).So my question in this PR is: is it ok to change the code to interpret
[]as "a zero address" and returnOk(None)here?