Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix rinkeby petersburg fork #10632

Merged
merged 1 commit into from
May 9, 2019
Merged

Fix rinkeby petersburg fork #10632

merged 1 commit into from
May 9, 2019

Conversation

Uxio0
Copy link
Contributor

@Uxio0 Uxio0 commented May 6, 2019

EIP1283 must be disabled on block 4321234 for Rinkeby (Petersburg fork)

@parity-cla-bot
Copy link

It looks like @Uxio0 hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@Uxio0
Copy link
Contributor Author

Uxio0 commented May 6, 2019

[clabot:check].

@parity-cla-bot
Copy link

It looks like @Uxio0 signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@jam10o-new
Copy link
Contributor

Reference in geth: ethereum/go-ethereum#19412

@jam10o-new jam10o-new added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. B1-patch-beta 🕷🕷 M2-config 📂 Chain specifications and node configurations. labels May 6, 2019
@jam10o-new jam10o-new added the A0-pleasereview 🤓 Pull request needs code review. label May 7, 2019
@soc1c soc1c added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels May 7, 2019
@soc1c
Copy link
Contributor

soc1c commented May 7, 2019

no rinkeby in stable - removing label

@soc1c
Copy link
Contributor

soc1c commented May 7, 2019

@paritytech/ci why is the gitlab status not reported correctly?

@soc1c soc1c added this to the 2.6 milestone May 7, 2019
@gabreal
Copy link
Contributor

gabreal commented May 8, 2019

it's now all green

@pdobacz
Copy link

pdobacz commented May 9, 2019 •
edited
Loading

For those who stumble upon not being able to sync to Rinkeby beyond 4321234 with:

Parity Ethereum
  version Parity-Ethereum/v2.5.0-beta-b52ac20-20190408/x86_64-linux-gnu/rustc1.33.0

because of an error:

Stage 5 block verification failed for #4321234 (0xe2fa…d424)
Error: Error(Block(InvalidStateRoot(Mismatch { expected: 0x575fa9830f18574d48a7f97c04a9b564ad7a12998aba64975a4d4456b264fbf1, found: 0x0c65eeb6fa8716c700ab446ffa622164dd7caf3827f8296a0e47242deba60ed5 })), State { next_error: None, backtrace: InternalBacktrace { backtrace: None } })

and get stuck on

Syncing #4321233 0x3fb3…c3d0     0.00 blk/s    0.0 tx/s

this seems to be the PR to look forward to :). Thanks to @InoMurko & @JBunCE for finding the way to here.

@jam10o-new jam10o-new merged commit de91a55 into openethereum:master May 9, 2019
@jam10o-new
Copy link
Contributor

@pdobacz you can use the chainspec directly from master (now that it's merged) until this is in a release.

@0x234
Copy link

0x234 commented May 9, 2019

Thanks - we've been able to fully sync to Rinkeby now.

soc1c pushed a commit that referenced this pull request May 10, 2019
@Uxio0 @soc1c
Fix rinkeby petersburg fork (#10632)
c091e4d
@soc1c soc1c mentioned this pull request May 10, 2019
Merged
9 tasks
soc1c added a commit that referenced this pull request May 10, 2019
@soc1c
beta 2.5.1 (#10643)
e0141f8 
* version: bump beta to 2.5.1

* fix(whisper expiry): current time + work + ttl (#10587)

* update bootnodes (#10595)

* config: update goerli bootnodes

* config: update kotti bootnodes

* adds rpc error message for --no-ancient-blocks (#10608)

* adds error message for --no-ancient-blocks, closes #10261

* Apply suggestions from code review

Co-Authored-By: seunlanlege <seunlanlege@gmail.com>

* Constantinople HF on POA Core (#10606)

* Constantinople HF on POA Core

Plan Constantinople/St.Petersfork HF on POA Core network at block 8582254.
Original PR in POA repository: poanetwork/poa-chain-spec#110

* Remove extra empty line

* evm: add some mulmod benches (#10600)

* evm: add blockhash_mulmod bench

* evm: use num-bigint for mod ops

* Clique: zero-fill extradata when the supplied value is less than 32 bytes in length (#10605)

* Update kovan.json to switch validator set to POA Consensus Contracts (#10628)

* Fix publish docs (#10635)

* Fix publish docs

* this never should be forced, either way compiling previous versions will produce outdated docs

* fix array, var was moved to the group project global variables list

* Fix rinkeby petersburg fork (#10632)
ordian added a commit that referenced this pull request May 16, 2019
@ordian
Merge branch 'master' into ao-upgrade-ethereum-types
a377aee 
* master:
  docs: Add ProgPoW Rust docs to ethash module (#10653)
  fix: Move PR template into .github/ folder (#10663)
  docs: Add PR template (#10654)
  Trivial journal for private transactions (#10056)
  fix(compilation warnings) (#10649)
  [whisper] Move needed aes_gcm crypto in-crate (#10647)
  Adds parity_getRawBlockByNumber, parity_submitRawBlock (#10609)
  Fix rinkeby petersburg fork (#10632)
  ci: publish docs debug (#10638)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jam10o-new jam10o-new jam10o-new approved these changes

@soc1c soc1c soc1c approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
7 participants
@Uxio0 @parity-cla-bot @jam10o-new @soc1c @gabreal @pdobacz @0x234