Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rel-703 pr #7976 #7276 snomed fixes #8041

Open
wants to merge 4 commits into
base: rel-703
Choose a base branch
from

Conversation

adunsulag
Copy link
Member

Backports PR for #7976, #7276

Update to support the 2024 file naming convention for us snomed-ct
* Improved code lookup for snomeds and large tables

Changed up the search mechanism for code types with external tables that
define a fulltext search on the search term.  Use the database search
features for improved lookup performance. Made this generic so it uses
all the same code lookup functionalities instead of specific to snomed.

Also made it so tables can define skipping the table count properties in
the find code files (find_code_dynamic and select_codes).

Made it so that ICD10 and other tables show a list of
codes when the finder first pops up, whereas snomed when it first shows
will show an empty table with a message that you need to put in a search term

I brought back the auto-complete typing though I bumped it up to 350ms
delay instead of 200ms delay.  This fixes the enter key closing the
dialog bug as well as makes the finder more usable.  With the improved
search performance the autocomplete now can function well.  Will have to
test this when there's a lot of concurrency.

Fixes openemr#7276

* Fix PSR styles

* Remove code_set_search_sct and unused comment

Not sure how my merge tool still included the code_set_search_sct method
even though I explicitly told it to not include it on the cherry-pick.
Either way, out it goes.

Also removed minor unused comment line.

* Fix table indexes for snomed ct codes

This speeds up the snomed lookup dramatically.

* Remove double spaces in files.
Table upgrades for the rel-703 need to go into the right spot for the
release.

Fixes openemr#7276
@adunsulag adunsulag changed the title Rel 703 pr 7976 7276 snomed fixes rel-703 pr #7976 #7276 snomed fixes Feb 18, 2025
@stephenwaite
Copy link
Member

should've given d6631c0 a better name :)

if you want to cherry-pick that here @adunsulag please

* fix: revert pr 8040

* add new line

* forgot to bump version

* revert revert :)
@adunsulag
Copy link
Member Author

@stephenwaite thanks for that fix. Cherry-picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants