Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improved handling of inserting and updating encounters #6647

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

robertdown
Copy link
Member

Just improve the way we are handling some data, better code formatting in a couple of ares.

When building the long inert SQL statement, we now combine the column names and values into an associative array which can be manipulated to make the building process a bit easier.

This doesn't actually add any new functionality or features, it is just a value-add for the development process

@stephenwaite
Copy link
Member

looks good @robertdown, prior formatting was to avoid the 120 character warning
Screenshot from 2023-07-10 10-32-00

@robertdown
Copy link
Member Author

We must have changed some rule because the test passed?

@stephenwaite
Copy link
Member

it's just a warning so doesn't fail tests

@robertdown robertdown merged commit 2ccff4a into openemr:master Jul 10, 2023
@adunsulag adunsulag added this to the 7.0.2 milestone Nov 10, 2023
@adunsulag adunsulag added the developers This issue targets an issue that is for developers/collaborators/module writers/technical users label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants