-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
librdkafka and cppkafka recipes #324
Conversation
SRCREV = "1a722553638bba85dbda5050455f7b9a5ef302de" | ||
|
||
DEPENDS = "zlib openssl zstd" | ||
RDEPENDS_${PN} = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this ?
SRCREV = "5e4b350806d561473138ce7a982e8f6cf2e77733" | ||
|
||
DEPENDS = "librdkafka boost" | ||
RDEPENDS_${PN} = "librdkafka" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed ? or can shlibs code automatically detect this dependency and add it to rdeps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
in |
Fails to configure see |
@kraj Strange. I started a new build on dunfell and couldn't get any error. |
Please test against master since it has to apply to master and then backported to dunfell if needed. |
@kraj I compiled again on master. Here is the logs.
This configurations were used.
|
the failure is seen with. |
@kraj Here is the results for master-next branchs.
|
I have restaged it in |
it still shows up, I think the reason is that librdkafka generates cmake with absolute paths into its build directory I see
in and this .cmake file is exported by librdkafka package these absolute paths is the problem, jenkins builders user rm_work so you can reproducre it like below
and you should see the issue |
From: hasan.men <hasan.men@bosphorusiss.com> | ||
Date: Sun, 4 Apr 2021 17:20:32 +0200 | ||
Subject: [PATCH] fix absolute path problem | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please submit this patch upstream as well. If its not worthy of upstream then added the status to patch comment so we know we have to carry it for a reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kraj I've already pushed. Just waiting for response. Thanks
still fails :( with latest patch, here are steps. diff --git a/meta-oe/recipes-support/librdkafka/librdkafka_1.6.1.bb b/meta-oe/recipes-support/librdkafka/librdkafka_1.6.1.bb
index 21a130e82b..f6be5cf1d5 100644
--- a/meta-oe/recipes-support/librdkafka/librdkafka_1.6.1.bb
+++ b/meta-oe/recipes-support/librdkafka/librdkafka_1.6.1.bb
@@ -19,3 +19,5 @@ inherit cmake
S = "${WORKDIR}/git"
FILES_${PN} += "${datadir}"
+
+inherit rm_work
|
* A patch is added to fix absolute path usage in cmake.
@kraj After lots of debugging I found problems with include path's of external packages. I changed their dependency because we don't them public to use librdkafka unless their FindPackage changed. I'll also push those changes to mainstream. I'm able to build with rm_work now. For my previous commit, I don't know how build passed with rm_work. I'm really sorry for that mistake. |
Hello @kraj, thank you for your support. Now, it's merged with master. What should I do in order to get these in dunfell? Which documentation should I read to learn meta-openembedded merge mechanism? |
usually new recipes are not often backported but you can make a case by creating a pull request against dunfell banch and stable maintainer will advice you accordingly. |
Changelog: ========== Add use_location_hints argument to document API for giving the option of ignoring XSI schema locations hints Fix import from locations hints with namespace mismatch (issue openembedded#324) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
License-Update: Rename LICENSE to LICENSE.txt and update copyright year * Ptest and library example tested on qemux86-64 and qemuarm64 * Add ptest into PTESTS_FAST_META_PYTHON qemux86-64: Testsuite summary TOTAL: 599 PASS: 599 SKIP: 0 XFAIL: 0 FAIL: 0 XPASS: 0 ERROR: 0 DURATION: 19 END: /usr/lib/python3-validators/ptest 2024-03-30T05:07 STOP: ptest-runner TOTAL: 1 FAIL: 0 qemuarm64: Testsuite summary TOTAL: 599 PASS: 599 SKIP: 0 XFAIL: 0 FAIL: 0 XPASS: 0 ERROR: 0 DURATION: 18 END: /usr/lib/python3-validators/ptest 2024-03-30T05:10 STOP: ptest-runner TOTAL: 1 FAIL: 0 Changelog: 0.24.0 =========== Features feat: conditionally raises ValidationError; bump version by @yozachar in openembedded#343 Maintenance patch: domain & url modules by @yozachar in openembedded#339 fix: domain name not confirming to rfc_2782 by @yozachar in openembedded#341 maint: update dev dependencies; adds favicon to docs by @yozachar in openembedded#342 0.23.2 =========== Maintenance maint: rectifies changelog by @yozachar in openembedded#336 fix: packaging as well as rST & md document generation by @yozachar in openembedded#337 0.23.1 =========== Maintenance maint: fix between & length validators by @yozachar in openembedded#334 fix: manual nav reference for mkdocs; bumps version by @yozachar in openembedded#335 0.23.0 =========== Features feat: add french i18n validation by @imperosol in openembedded#308 Maintenance fix: Valid URLs failing validation - query and fragment parts by @danherbriley in openembedded#297 fix: bug in between module by @yozachar in openembedded#301 chore: update dependencies, improve packaging by @yozachar in openembedded#304 Fix fragment check by @darkdragon-001 in openembedded#305 build(deps): bump urllib3 from 2.0.6 to 2.0.7 in /package by @dependabot in openembedded#310 fix: allow pct-encoded entities in fragments by @conitrade-as in openembedded#317 chore: update dev dependencies by @yozachar in openembedded#318 build(deps): bump gitpython from 3.1.37 to 3.1.41 in /package by @dependabot in openembedded#321 build(deps): bump jinja2 from 3.1.2 to 3.1.3 in /package by @dependabot in openembedded#322 chore: monthly updates for Jan'24 by @yozachar in openembedded#324 maint: adds versiond docs; update copyright year by @yozachar in openembedded#329 chore: update dev dependencies by @yozachar in openembedded#330 build(deps): bump gitpython from 3.1.37 to 3.1.41 in /package by @dependabot in openembedded#331 build(deps): bump jinja2 from 3.1.2 to 3.1.3 in /package by @dependabot in openembedded#332 build(deps): bump urllib3 from 2.0.6 to 2.0.7 in /package by @dependabot in openembedded#319 Signed-off-by: alperak <alperyasinak1@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
License-Update: Rename LICENSE to LICENSE.txt and update copyright year * Ptest and library example tested on qemux86-64 and qemuarm64 * Add ptest into PTESTS_FAST_META_PYTHON qemux86-64: Testsuite summary TOTAL: 599 PASS: 599 SKIP: 0 XFAIL: 0 FAIL: 0 XPASS: 0 ERROR: 0 DURATION: 19 END: /usr/lib/python3-validators/ptest 2024-03-30T05:07 STOP: ptest-runner TOTAL: 1 FAIL: 0 qemuarm64: Testsuite summary TOTAL: 599 PASS: 599 SKIP: 0 XFAIL: 0 FAIL: 0 XPASS: 0 ERROR: 0 DURATION: 18 END: /usr/lib/python3-validators/ptest 2024-03-30T05:10 STOP: ptest-runner TOTAL: 1 FAIL: 0 Changelog: 0.24.0 =========== Features feat: conditionally raises ValidationError; bump version by @yozachar in #343 Maintenance patch: domain & url modules by @yozachar in #339 fix: domain name not confirming to rfc_2782 by @yozachar in #341 maint: update dev dependencies; adds favicon to docs by @yozachar in #342 0.23.2 =========== Maintenance maint: rectifies changelog by @yozachar in #336 fix: packaging as well as rST & md document generation by @yozachar in #337 0.23.1 =========== Maintenance maint: fix between & length validators by @yozachar in #334 fix: manual nav reference for mkdocs; bumps version by @yozachar in #335 0.23.0 =========== Features feat: add french i18n validation by @imperosol in #308 Maintenance fix: Valid URLs failing validation - query and fragment parts by @danherbriley in #297 fix: bug in between module by @yozachar in #301 chore: update dependencies, improve packaging by @yozachar in #304 Fix fragment check by @darkdragon-001 in #305 build(deps): bump urllib3 from 2.0.6 to 2.0.7 in /package by @dependabot in #310 fix: allow pct-encoded entities in fragments by @conitrade-as in #317 chore: update dev dependencies by @yozachar in #318 build(deps): bump gitpython from 3.1.37 to 3.1.41 in /package by @dependabot in #321 build(deps): bump jinja2 from 3.1.2 to 3.1.3 in /package by @dependabot in #322 chore: monthly updates for Jan'24 by @yozachar in #324 maint: adds versiond docs; update copyright year by @yozachar in #329 chore: update dev dependencies by @yozachar in #330 build(deps): bump gitpython from 3.1.37 to 3.1.41 in /package by @dependabot in #331 build(deps): bump jinja2 from 3.1.2 to 3.1.3 in /package by @dependabot in #332 build(deps): bump urllib3 from 2.0.6 to 2.0.7 in /package by @dependabot in #319 Signed-off-by: alperak <alperyasinak1@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Changelog: =========== - Fixes openembedded#409: IndexError on empty strong mark. - Fix openembedded#332: Insert at most one space for multiple emphasis - Feature openembedded#318: Make padded tables more similar to pandoc's pipe_tables. - Add support for Python 3.9. - Fix extra line breaks inside html link text (between '[' and ']') - Fix openembedded#344: indent <ul> inside <ol> three spaces instead of two to comply with CommonMark, GFM, etc. - Fix openembedded#324: unnecessary spaces around <b>, <em>, and strike tags. - Don't wrap tables by default and add a --wrap-tables config option. - Feature openembedded#198: Ignore <p> tags inside table rows. - Don't wrap tables by default and add a --wrap-tables config option - Remove support for Python <= 3.5. Now requires Python 3.6+. - Support for Python 3.10+. - Fix openembedded#320 padding empty tables and tables with no </tr> tags. - Add ignore_mailto_links config option to ignore mailto: style links. - Feature openembedded#407: Support the superscript and subscript tags. - Fix openembedded#373: \n inside text of a Markdown link. - Feature openembedded#406: Improve support for null atttibute values. Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
I couldn't find kafka related recipes in meta-oe and opened this pr.
librdkafka is widely used in new IOT projects