fix: misuse of gettext in JS

openedx · Apr 10, 2023 · e667807 · e667807
1 parent 4a210a8
commit e667807
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/lti_consumer/static/js/xblock_lti_consumer.js b/lti_consumer/static/js/xblock_lti_consumer.js
@@ -154,21 +154,20 @@ function LtiConsumerXBlock(runtime, element) {
 
         function renderPIIConsentPromptIfRequired(onSuccess, showCancelButton=true) {
             if (askToSendUsername && askToSendEmail) {
-                msg = "Click OK to have your username and e-mail address sent to a 3rd party application.";
+                msg = gettext("Click OK to have your username and e-mail address sent to a 3rd party application.");
             } else if (askToSendUsername) {
-                msg = "Click OK to have your username sent to a 3rd party application.";
+                msg = gettext("Click OK to have your username sent to a 3rd party application.");
             } else if (askToSendEmail) {
-                msg = "Click OK to have your e-mail address sent to a 3rd party application.";
+                msg = gettext("Click OK to have your e-mail address sent to a 3rd party application.");
             } else {
                 onSuccess("OK");
                 return;
             }
 
             if (showCancelButton) {
-                msg += "\n\nClick Cancel to return to this page without sending your information.";
+                msg += "\n\n" + gettext("Click Cancel to return to this page without sending your information.");
             }
 
-            msg = gettext(msg);
             $.when(confirmDialog(msg, $(this), showCancelButton)).then(onSuccess);
         }