Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update edx lint constraint #194

Merged
merged 2 commits into from
Mar 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
# SERIOUSLY.
#
# ------------------------------
# Generated by edx-lint version: 5.2.5
# Generated by edx-lint version: 5.3.6
# ------------------------------
[MASTER]
ignore = migrations
Expand Down Expand Up @@ -259,6 +259,7 @@ enable =
useless-suppression,
disable =
bad-indentation,
broad-exception-raised,
consider-using-f-string,
duplicate-code,
file-ignored,
Expand Down Expand Up @@ -286,9 +287,16 @@ disable =
illegal-waffle-usage,

logging-fstring-interpolation,
no-self-use,
logging-format-interpolation,
useless-suppression,
consider-using-with,
super-with-arguments,
raise-missing-from,
unnecessary-dunder-call,
f-string-without-interpolation,
no-member,
redundant-u-string-prefix,
missing-timeout,

[REPORTS]
output-format = text
Expand Down Expand Up @@ -383,6 +391,6 @@ ext-import-graph =
int-import-graph =

[EXCEPTIONS]
overgeneral-exceptions = Exception
overgeneral-exceptions = builtins.Exception

# c0857a3261a064e2a276a399b5ec398fd1738e0f
# e6b9210c4ebb3c7cfd90813ff591f1a239499995
9 changes: 8 additions & 1 deletion pylintrc_tweaks
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ load-plugins = edx_lint.pylint,pylint_django,pylint_celery

[MESSAGES CONTROL]
disable+ =
no-self-use,
logging-format-interpolation,
useless-suppression,
consider-using-with,
super-with-arguments,
raise-missing-from,
unnecessary-dunder-call,
f-string-without-interpolation,
no-member,
redundant-u-string-prefix,
missing-timeout,
12 changes: 6 additions & 6 deletions requirements/ci.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@
#
# make upgrade
#
distlib==0.3.7
distlib==0.3.8
# via virtualenv
filelock==3.12.4
filelock==3.13.1
# via
# tox
# virtualenv
packaging==23.2
packaging==24.0
# via tox
platformdirs==3.11.0
platformdirs==4.2.0
# via virtualenv
pluggy==1.3.0
pluggy==1.4.0
# via tox
py==1.11.0
# via tox
Expand All @@ -26,5 +26,5 @@ tox==3.28.0
# via
# -c requirements/constraints.txt
# -r requirements/ci.in
virtualenv==20.24.5
virtualenv==20.25.1
# via tox
3 changes: 0 additions & 3 deletions requirements/constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ path==13.1.0

celery<5.0

# pinning because latest version of pylint is causing lot of failures
edx-lint<=1.5.2

# latest version causing issues in discovery.
algoliasearch-django<4.0.0
algoliasearch<2.0.0
Expand Down
Loading
Loading