Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat!: release chip, searchfield, pagination, form.autosuggest (#2964)" #2994

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

adamstankiewicz
Copy link
Member

This reverts commit 0274f10.

Description

The reverted commit was not properly released to NPM. We will try again but properly including the BREAKING CHANGE message in the commit body in an attempt to get semantic-release to recognize the changes/release.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 08d18d6
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/65aa8d8a054ad40008b80330
😎 Deploy Preview https://deploy-preview-2994--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 let's hope semantic release likes this next time!

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (0274f10) 93.18% compared to head (08d18d6) 93.00%.

Files Patch % Lines
src/Pagination/index.jsx 96.40% 5 Missing ⚠️
src/Form/FormAutosuggest.jsx 97.08% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2994      +/-   ##
==========================================
- Coverage   93.18%   93.00%   -0.19%     
==========================================
  Files         249      236      -13     
  Lines        4342     4273      -69     
  Branches     1036     1033       -3     
==========================================
- Hits         4046     3974      -72     
- Misses        292      295       +3     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit 4ba0b6d into master Jan 19, 2024
10 checks passed
@adamstankiewicz adamstankiewicz deleted the revert-v22-release branch January 19, 2024 15:34
@openedx-semantic-release-bot

🎉 This PR is included in version 22.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants