Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: replace custom submit and reset btns with IconButton #2842

Conversation

khudym
Copy link
Contributor

@khudym khudym commented Nov 23, 2023

Description

Replace custom Searchfield buttons with IconButton
Issue

Deploy Preview

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Nov 23, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @khudym!

When this pull request is ready, tag your edX technical lead.

@khudym
Copy link
Contributor Author

khudym commented Nov 23, 2023

Old PR: #2719

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9face09) 92.83% compared to head (56ba018) 92.83%.
Report is 67 commits behind head on release/chip-searchfield-pagination.

Additional details and impacted files
@@                           Coverage Diff                           @@
##           release/chip-searchfield-pagination    #2842      +/-   ##
=======================================================================
- Coverage                                92.83%   92.83%   -0.01%     
=======================================================================
  Files                                      235      235              
  Lines                                     4241     4240       -1     
  Branches                                  1029     1029              
=======================================================================
- Hits                                      3937     3936       -1     
  Misses                                     300      300              
  Partials                                     4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit d132fcf into openedx:release/chip-searchfield-pagination Dec 8, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants