Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: [BD-46] skeleton.css for both dev and prod (#2531)" #2562

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

adamstankiewicz
Copy link
Member

This reverts commit 7e96a0a.

Description

Reverts #2531 as it still seems to be causing issues for consuming MFEs (e.g., frontend-template-application). That is, an MFE was unable to start/build with the changes in this prior commit even though testing the same MFE through module.config.js worked without issue.

Deploy Preview

n/a

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 00abbfe
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64df80a31fd7100008af9275
😎 Deploy Preview https://deploy-preview-2562--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamstankiewicz adamstankiewicz merged commit 4d4577e into master Aug 18, 2023
7 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/revert-skeleton-css branch August 18, 2023 14:32
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants