Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selectable box set props forwarding #2461

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

MaxFrank13
Copy link
Member

@MaxFrank13 MaxFrank13 commented Jul 20, 2023

Description

This sets up the ability to forward props directly to the root element of the SelectableBoxSet component. This came up originally to enable to ability to provide an aria-labelledby attribute to the SelectableBoxSet. This will support adding other attributes should the need come up in the future.

Deploy Preview

Preview of changes

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit f29e3e0
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64da81c7c132540008d65720
😎 Deploy Preview https://deploy-preview-2461--paragon-openedx.netlify.app/components/selectablebox
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (314b116) 91.39% compared to head (e334a59) 91.42%.
Report is 36 commits behind head on master.

❗ Current head e334a59 differs from pull request most recent head f29e3e0. Consider uploading reports for the commit f29e3e0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2461      +/-   ##
==========================================
+ Coverage   91.39%   91.42%   +0.02%     
==========================================
  Files         234      234              
  Lines        4161     4161              
  Branches     1001     1001              
==========================================
+ Hits         3803     3804       +1     
+ Misses        351      350       -1     
  Partials        7        7              
Files Changed Coverage Δ
src/SelectableBox/SelectableBoxSet.jsx 90.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxFrank13 MaxFrank13 force-pushed the mfrank/seletable-box-set-fix branch from e334a59 to e33e56d Compare July 26, 2023 18:32
src/SelectableBox/SelectableBoxSet.jsx Show resolved Hide resolved
src/SelectableBox/SelectableBoxSet.jsx Show resolved Hide resolved
src/SelectableBox/tests/SelectableBoxSet.test.jsx Outdated Show resolved Hide resolved
@MaxFrank13
Copy link
Member Author

MaxFrank13 commented Aug 9, 2023

Changes in latest push:

  • changed toBeTruthy() to toBeInTheDocument()
  • added ariaLabel to test components and updated snapshot accordingly

BREAKING CHANGE: aria-label is required when not using aria-labelledby
in the SelectableBoxSet component. An associated label for the component is a WCAG requirement.
@MaxFrank13 MaxFrank13 merged commit 1d6f95e into master Aug 15, 2023
9 checks passed
@MaxFrank13 MaxFrank13 deleted the mfrank/seletable-box-set-fix branch August 15, 2023 13:21
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants