Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-46] feat: added missing SCSS variables in design tokens #2364

Merged
merged 2 commits into from
Jun 16, 2023
Merged

[BD-46] feat: added missing SCSS variables in design tokens #2364

merged 2 commits into from
Jun 16, 2023

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Jun 9, 2023 •
edited
Loading

Description

  • Similar to the case of a missing design token for $rounded-pill, let's use this issue as a sanity check around trying to find any other potentially design tokens missing for existing SCSS variables.

Issue: #2347

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 9, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 9, 2023 •
edited
Loading

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft June 9, 2023 08:03
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title feat: added missing SCSS variables in design tokens [BD-46] feat: added missing SCSS variables in design tokens Jun 9, 2023
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program and removed open-source-contribution PR author is not from Axim or 2U labels Jun 9, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this pull request Jun 9, 2023
Closed
@codecov
Copy link

codecov bot commented Jun 9, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (39fe41d) 91.58% compared to head (c2c77e6) 91.58%.

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #2364   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         214      214           
  Lines        3519     3519           
  Branches      852      852           
=======================================
  Hits         3223     3223           
  Misses        288      288           
  Partials        8        8

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/missing-SCSS-variables-in-design-tokens branch from 37a9568 to e7bd5bd Compare June 9, 2023 10:49
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review June 9, 2023 10:51
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/missing-SCSS-variables-in-design-tokens branch from e7bd5bd to 783d4fb Compare June 9, 2023 10:52
@viktorrusakov viktorrusakov linked an issue Jun 9, 2023 that may be closed by this pull request
Try to find additional missing SCSS variables in design tokens #2347
Closed
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft June 9, 2023 12:00
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review June 15, 2023 15:20
PKulkoRaccoonGang
PKulkoRaccoonGang commented Jun 15, 2023
View reviewed changes
styles/scss/core/bootstrap-override/mixins/_grid-framework.scss Outdated
position: relative;
width: 100%;
padding-right: calc($gutter * .5);
padding-left: calc($gutter * .5);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In these files, we have small changes

For example padding-right: $gutter * .5 to padding-right: calc($gutter * .5)

@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this pull request Jun 15, 2023
Closed
@PKulkoRaccoonGang
Copy link
Contributor Author

Brand: edx/brand-edx.org#68

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/missing-SCSS-variables-in-design-tokens branch from 1509b7f to c2c77e6 Compare June 16, 2023 08:51
@adamstankiewicz adamstankiewicz merged commit 86df23e into openedx:alpha Jun 16, 2023
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.0-alpha.39 🎉

The release is available on:

Your semantic-release bot 📦🚀

monteri pushed a commit to raccoongang/paragon that referenced this pull request Aug 17, 2023
@PKulkoRaccoonGang
fix: added missing SCSS variables in design tokens (openedx#2364)
9c5f7a6 
* feat: added missing SCSS variables in design tokens
* feat: added grid-gutter-width token
PKulkoRaccoonGang added a commit to raccoongang/paragon that referenced this pull request Aug 18, 2023
@PKulkoRaccoonGang
fix: added missing SCSS variables in design tokens (openedx#2364)
88e0a41 
* feat: added missing SCSS variables in design tokens
* feat: added grid-gutter-width token
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 23.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

PKulkoRaccoonGang added a commit that referenced this pull request Aug 1, 2024
@PKulkoRaccoonGang
fix: added missing SCSS variables in design tokens (#2364)
2304eb2 
* feat: added missing SCSS variables in design tokens
* feat: added grid-gutter-width token
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
@PKulkoRaccoonGang
fix: added missing SCSS variables in design tokens (#2364)
3851c25 
* feat: added missing SCSS variables in design tokens
* feat: added grid-gutter-width token
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
@PKulkoRaccoonGang
fix: added missing SCSS variables in design tokens (#2364)
53ab850 
* feat: added missing SCSS variables in design tokens
* feat: added grid-gutter-width token
PKulkoRaccoonGang added a commit that referenced this pull request Aug 5, 2024
@PKulkoRaccoonGang
fix: added missing SCSS variables in design tokens (#2364)
108c2c5 
* feat: added missing SCSS variables in design tokens
* feat: added grid-gutter-width token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

@monteri monteri monteri approved these changes

Assignees
No one assigned
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha
Projects
Contributions
Archived in project
2U Blended Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try to find additional missing SCSS variables in design tokens
6 participants
@PKulkoRaccoonGang @openedx-webhooks @edx-semantic-release @openedx-semantic-release-bot @adamstankiewicz @monteri