Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add platform-plugin-aspects repo to translations #5883

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Apr 9, 2024

It's been a while since I've done one of these, so it's entirely possible I missed a step here.

Copy link

github-actions bot commented Apr 9, 2024

✅ All translation files are valid.

This comment has been posted by the validate-translation-files.yml GitHub Actions workflow.

@bmtcril
Copy link
Contributor Author

bmtcril commented Apr 16, 2024

@brian-smith-tcril I've tested this on a fork against latest platform-plugin-aspects and I think it should be good to go now.

Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@OmarIthawi
Copy link
Member

@bmtcril I suppose you've already followed the testing steps here:

It makes me think that we should add it to the pull request template.

@bmtcril
Copy link
Contributor Author

bmtcril commented Apr 16, 2024

I think those directions are a little out of date, but I did test extract_translations in my fork against the new repo

@brian-smith-tcril brian-smith-tcril merged commit a929393 into main Apr 19, 2024
5 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bmtcril/add_platform_plugin_aspects branch April 19, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants