Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate po files on pull_request #564

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Aug 17, 2023

TODO

Post-merge


This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 17, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 17, 2023

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Are there any other checks you'd like add for validation (maybe on the js side of things?)

@brian-smith-tcril brian-smith-tcril merged commit b00ce67 into openedx:main Aug 18, 2023
4 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@OmarIthawi
Copy link
Member Author

This looks great! Are there any other checks you'd like add for validation (maybe on the js side of things?)

Yes, there are other minor improvements. I'll add more details to the issue: #549

This is probably the main check that we need need. For JavaScript, I'm not aware of a msgfmt alternative but I think we can find one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants