Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix wrong key (repo) to be (repo_name) #478

Merged

Conversation

shadinaif
Copy link
Contributor

My bad! the key I used for these repositories was repo which is wrong. The correct one is repo_name

@openedx-webhooks
Copy link

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 23, 2023
@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.fix-repo_name branch from c54a8b1 to c64dbdc Compare July 23, 2023 14:42
@shadinaif shadinaif changed the title feat: Fix wrong key (repo) to be (repo_name) fix: Fix wrong key (repo) to be (repo_name) Jul 23, 2023
@shadinaif
Copy link
Contributor Author

@OmarIthawi please review. Translation is broken for these repositories, this is the fix

@OmarIthawi OmarIthawi merged commit d9b2436 into openedx:main Jul 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants