Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add xblock-lti-consumer to the translation pipeline #151

Merged
merged 1 commit into from
Apr 25, 2023
Merged

feat: Add xblock-lti-consumer to the translation pipeline #151

merged 1 commit into from
Apr 25, 2023

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Mar 16, 2023 •
edited by brian-smith-tcril
Loading

feat: Add xblock-lti-consumer to the translation pipeline

IMPORTANT: This PR needs openedx/xblock-lti-consumer#341 before it's merged.

Refs:
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
see details here

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 16, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

MichaelRoytman
MichaelRoytman approved these changes Mar 16, 2023
View reviewed changes
Copy link

@MichaelRoytman MichaelRoytman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the way this repository or the workflow that runs xblock-lti-consumer's extract-translations make target works, but this looks like it aligns with the changes you've made in openedx/xblock-lti-consumer#341.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 21, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 24, 2023
@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.xblock-lti-consumer branch 2 times, most recently from ae14084 to e696147 Compare April 14, 2023 13:11
@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.xblock-lti-consumer branch from e696147 to 726a9fb Compare April 25, 2023 08:13
@brian-smith-tcril brian-smith-tcril merged commit e9f9b8c into openedx:main Apr 25, 2023
@openedx-webhooks
Copy link

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@brian-smith-tcril brian-smith-tcril added the adding repo PRs adding repositories to the translation pipeline label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelRoytman MichaelRoytman MichaelRoytman approved these changes

@brian-smith-tcril brian-smith-tcril brian-smith-tcril approved these changes

Assignees
No one assigned
Labels
adding repo PRs adding repositories to the translation pipeline open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shadinaif @openedx-webhooks @MichaelRoytman @brian-smith-tcril @e0d @mphilbrick211