Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add xblock-drag-and-drop-v2 to the translation pipeline #146

Merged
merged 1 commit into from
Apr 20, 2023
Merged

feat: Add xblock-drag-and-drop-v2 to the translation pipeline #146

merged 1 commit into from
Apr 20, 2023

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Mar 13, 2023 •
edited
Loading

feat: Add xblock-drag-and-drop-v2 to the translation pipeline

IMPORTANT: This PR needs openedx/xblock-drag-and-drop-v2#316 before it's merged.

Refs: see details here

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 13, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 16, 2023
@e0d
Copy link

e0d commented Mar 21, 2023

@mphilbrick211 tests passed.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 21, 2023
@brian-smith-tcril brian-smith-tcril added blocked by other work PR cannot be finished until other work is complete waiting on another PR and removed blocked by other work PR cannot be finished until other work is complete labels Mar 23, 2023
@itsjeyd itsjeyd added blocked by other work PR cannot be finished until other work is complete waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting on another PR labels Apr 5, 2023
@itsjeyd
Copy link

itsjeyd commented Apr 5, 2023

@shadinaif Just a friendly reminder to resolve merge conflicts here.

@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.xblock-drag-and-drop-v2 branch from c7e7f38 to cd3ecc7 Compare April 10, 2023 05:25
@shadinaif
Copy link
Contributor Author

Done @itsjeyd , thanks for the reminder. This must wait for openedx/xblock-drag-and-drop-v2#316 to be merged

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 11, 2023
@itsjeyd
Copy link

itsjeyd commented Apr 13, 2023

@shadinaif Noted, thanks. Changing status to Blocked for now.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 14, 2023
@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.xblock-drag-and-drop-v2 branch from cd3ecc7 to cccef5f Compare April 15, 2023 09:53
@itsjeyd itsjeyd removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. blocked by other work PR cannot be finished until other work is complete labels Apr 20, 2023
@itsjeyd
Copy link

itsjeyd commented Apr 20, 2023

@shadinaif Looks like this is unblocked now (openedx/xblock-drag-and-drop-v2#316 has been merged, and build is green 🎉)! Marking as ready for review.

@openedx/axim-engineering This PR is ready for engineering review.

CC @mphilbrick211

@sarina
Copy link
Contributor

sarina commented Apr 20, 2023

FYI @itsjeyd - this is part of FC-12 and you should tag @brian-smith-tcril rather than the whole eng team on that.

@shadinaif could you be sure to put "FC-12" in the PR title or description?

@itsjeyd
Copy link

itsjeyd commented Apr 20, 2023

Noted, thanks @sarina ☑️

@brian-smith-tcril brian-smith-tcril merged commit 60ea19b into openedx:main Apr 20, 2023
@openedx-webhooks
Copy link

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

This was referenced Oct 10, 2023
Merged
Merged
Merged
@itsjeyd itsjeyd mentioned this pull request Oct 10, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-smith-tcril brian-smith-tcril brian-smith-tcril approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shadinaif @openedx-webhooks @e0d @itsjeyd @sarina @brian-smith-tcril @mphilbrick211