feat: add lms_user_email and content_tile to Transactions #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnagro
force-pushed
the
johnnagro/ENT-7867/0
branch
2 times, most recently
from
124d699 to
00cd171
Compare
| @@ -353,6 +363,16 @@ class Meta: | |||
| "The globally unique content identifier. Joinable with ContentMetadata.content_key in enterprise-catalog." | |||
| ) | |||
| ) | |||
| content_title = models.CharField( | |||
| max_length=255, | |||
There was a problem hiding this comment.
This may be too short for content titles.
There was a problem hiding this comment.
Looks like discovery uses 255 - https://github.com/openedx/course-discovery/blob/master/course_discovery/apps/course_metadata/models.py#L1319
make it bigger here anyway?
openedx_ledger/models.py
Outdated
| db_index=True, | ||
| help_text=( | ||
| "The email of the Open edX LMS user record with which this Transaction is associated." | ||
| "The email is captured at the time the Transaction is created may not be up to date." |
There was a problem hiding this comment.
nit: missing "and" in "Transaction is created may not"?
openedx_ledger/models.py
Outdated
| db_index=True, | ||
| help_text=( | ||
| "The title of the content associated with this Transaction." | ||
| "The title is captured at the time the Transaction is created may not be up to date." |
| @@ -0,0 +1,25 @@ | |||
| # Docker in this repo is only supported for running tests locally | |||
| # as an alternative to virtualenv natively - johnnagro 2022-02-11 | |||
macdiesel
approved these changes
Oct 24, 2023
johnnagro
force-pushed
the
johnnagro/ENT-7867/0
branch
from
00cd171 to
6d24559
Compare
johnnagro
force-pushed
the
johnnagro/ENT-7867/0
branch
from
6d24559 to
6a164fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
lms_user_emailandcontent_tilefields to Transactions.make test-shellcribbed fromedx-enterpriseIn support of: