Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Open edX app theming capability improvements #99

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

omerhabib26
Copy link
Contributor

@omerhabib26 omerhabib26 commented Nov 16, 2023

How we can update the theme:-

Steps to be followed:-

  1. Create a resource directory that needs to be customized i.e., Fonts and Resources.
    • Path: core/src/{directory_name}/res/
    • Add only those resources that need to be customized i.e, logo, symbols or icons
    • Place the font.xml file in the src/{directory_name}/res/font directory, alongside the font files.
  2. Update the resource path from core/build.gradle.
    sourceSets {
       {enviorment_name} {
            res.srcDirs = ['src/{directory_name}/res']
        }
    }
    
  3. Update the Colors.kt according to the desired colors.

Pre-requisite:-

  • We need to move colors codes from theme.kt to a separate Colors.kt as per material design recommendations. We can also follow the naming conventions suggested by the Material Design 3.
  • We should specify fonts for the application rather than relying on the device's default fonts, and it's essential to update the font references in Type.kt.
    • It's advisable to include certain default fonts within the codebase.

PS: As we are going for new architecture we should migrate to Material.io 3.

- Add the capability to make code easily customisable
- Move the customisable resources to a separate directory
- Move the colors to separate Colors.kt

fix: LEARNER-9693
@volodymyr-chekyrta
Copy link
Contributor

Looks good to me 👍.
It's a draft. Should we merge or expect more in this PR?

@omerhabib26 omerhabib26 changed the title [DRAFT]feat: Open edX app theming capability improvements feat: Open edX app theming capability improvements Nov 22, 2023
@omerhabib26 omerhabib26 marked this pull request as ready for review November 22, 2023 11:11
@omerhabib26
Copy link
Contributor Author

Looks good to me 👍. It's a draft. Should we merge or expect more in this PR?

we can merge it now. 🚀

@volodymyr-chekyrta volodymyr-chekyrta merged commit b8dd820 into openedx:develop Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants