feat: login with Google, Facebook, Microsoft #89

k1rill · 2023-11-09T13:57:55Z

Added Sign In buttons for:

Google
Facebook
Microsoft

SDK integration guides:
https://developer.android.com/training/sign-in/credential-manager
https://developers.facebook.com/docs/facebook-login/android/
https://github.com/AzureAD/microsoft-authentication-library-for-android

To turn on this feature you need to set ffShowSocialLogin flag to true in the config.yaml file.
Also in the config.yaml was added new configuration fields:

    SOCIAL:
      GOOGLE_CLIENT_ID: ""
      FACEBOOK_APP_ID: ""
      FACEBOOK_CLIENT_TOKEN: ""
      MICROSOFT_CLIENT_ID: ""
      MICROSOFT_PACKAGE_SIGN: ""

Screenshots:

farhan-arshad-dev · 2023-11-13T15:36:15Z

auth/src/main/java/org/openedx/auth/domain/interactor/MicrosoftSignInInteractor.kt

+    private val configFile = File.createTempFile("config", null)
+        .also {
+            it.writeText(configJson)
+        }


IMO, better to create the config file on build time.

changed to gradle realisation

farhan-arshad-dev · 2023-11-14T06:24:37Z

@k1rill what if ffShowSocialLogin is set to true, but GOOGLE_CLIENT_ID key is not available? Will the application display the Google sign-in button?

Also, Is there a provision to conceal specific social login options in the current implementation?

k1rill · 2023-11-15T11:12:45Z

@k1rill what if ffShowSocialLogin is set to true, but GOOGLE_CLIENT_ID key is not available? Will the application display the Google sign-in button?

Also, Is there a provision to conceal specific social login options in the current implementation?

@farhan-arshad-dev this realisation is for edX as for now, so all config fields are required.

volodymyr-chekyrta · 2023-11-16T17:17:49Z

@k1rill and I have discussed and resolved all critical issues.
Everything looks good and ready to merge.

volodymyr-chekyrta · 2023-11-24T09:39:09Z

@farhan-arshad-dev waiting for your review, please take a look

omerhabib26

Unable to test the Google & Microsoft login due to keys issue.
@k1rill Please rebase the code with the latest the develop branch and use the colors from Colors.kt

config.yaml

core/src/main/java/org/openedx/core/ApiConstants.kt

core/build.gradle

config.yaml

core/src/main/AndroidManifest.xml

auth/src/main/java/org/openedx/auth/presentation/signin/SignInViewModel.kt

auth/src/main/java/org/openedx/auth/presentation/sso/GoogleAuthHelper.kt

auth/src/main/java/org/openedx/auth/presentation/signin/compose/SignInView.kt

farhan-arshad-dev

I'm currently looking at how we can test Microsoft login, cuz with the available keys|configs are not working with the current implementation.

farhan-arshad-dev

Did the manual testing, Results are as follows.

Microsoft login working as expected with some code changes.
Unable to log-in with Facebook need to check the implementation.
Unable to log-in with Google need to verify the configs on our side.

farhan-arshad-dev · 2023-12-05T06:01:46Z

core/build.gradle

+    def social = config.get("SOCIAL")
+    def facebookAppId = social.getOrDefault("FACEBOOK_APP_ID", "")
+    def facebookClientToken = social.getOrDefault("FACEBOOK_CLIENT_TOKEN", "")


we should handle the case if keys are not available. e.g SOCIAL

farhan-arshad-dev · 2023-12-07T06:27:18Z

default_config/dev/config.yaml

+SOCIAL:
+  GOOGLE_CLIENT_ID: ""
+  FACEBOOK_APP_ID: ""
+  FACEBOOK_CLIENT_TOKEN: ""
+  MICROSOFT_CLIENT_ID: ""
+  MICROSOFT_PACKAGE_SIGNATURE: ""
+


Update the config format as follows

SOCIAL_AUTH_ENABLED: true | false GOOGLE: ENABLED: true | false CLIENT_ID: '' MICROSOFT: ENABLED: true | false CLIENT_ID: '' PACKAGE_SIGNATURE: '' FACEBOOK: ENABLED: true | false FACEBOOK_APP_ID: '' CLIENT_TOKEN: ''

Reasons:

iOS used the same format.

Allows the developer to disable | enable a particular Social auth.

Allows to disable the social auth and retain the key if want.

Minimum effort of migration to new configs.

ps: Can create the config changes PR like pull#157

farhan-arshad-dev · 2023-12-07T06:29:53Z

buildSrc/src/main/groovy/org/edx/builder/ConfigHelper.groovy

+                client_id                     : clientId,
+                authorization_user_agent      : "DEFAULT",
+                redirect_uri                  : "msauth://$applicationId/$sign",
+                account_mode                  : "SINGLE",


Currently, edx microsoft config only supports `account_mode : "MULTIPLE" for now.

farhan-arshad-dev · 2023-12-07T06:31:50Z

auth/src/main/java/org/openedx/auth/presentation/sso/MicrosoftAuthHelper.kt

+        suspendCancellableCoroutine { continuation ->
+            val clientApplication =
+                PublicClientApplication.createSingleAccountPublicClientApplication(
+                    activityContext,
+                    R.raw.microsoft_auth_config
+                )
+            val params = AcquireTokenParameters.Builder()
+                .startAuthorizationFromActivity(activityContext)
+                .withScopes(SCOPES)
+                .withCallback(object : AuthenticationCallback {
+                    override fun onSuccess(authenticationResult: IAuthenticationResult?) {
+                        continuation.resume(authenticationResult?.accessToken)
+                    }
+
+                    override fun onError(exception: MsalException) {
+                        logger.e { "Microsoft auth error: $exception" }
+                        continuation.resumeWithException(exception)
+                    }
+
+                    override fun onCancel() {
+                        logger.d { "Microsoft auth canceled" }
+                        continuation.resume("")
+                    }
+                }).build()
+            clientApplication.acquireToken(params)


need to update the code as per account_mode : "MULTIPLE".

can use the following.

suspendCancellableCoroutine { continuation -> PublicClientApplication.createMultipleAccountPublicClientApplication(activityContext, R.raw.microsoft_auth_config, object : IPublicClientApplication.IMultipleAccountApplicationCreatedListener { override fun onCreated(application: IMultipleAccountPublicClientApplication) { application.acquireToken( AcquireTokenParameters.Builder() .startAuthorizationFromActivity(activityContext) .withScopes(SCOPES) .withCallback(object : AuthenticationCallback { override fun onSuccess(authenticationResult: IAuthenticationResult?) { continuation.resume(authenticationResult?.accessToken) } override fun onError(exception: MsalException) { logger.e { "Microsoft auth error: $exception" } continuation.resumeWithException(exception) } override fun onCancel() { logger.d { "Microsoft auth canceled" } continuation.resume("") } }) .build() ) } override fun onError(exception: MsalException) { logger.e { "Microsoft auth error: $exception" } continuation.resumeWithException(exception) } }) }

miankhalid

I've talked with @farhan-arshad-dev (who isn't available today) and per his feedback we're good to go with merging this PR. I'm approving the PR on his behalf.

@volodymyr-chekyrta feel free to approve & merge the PR, thanks! 🚀

k1rill requested a review from volodymyr-chekyrta November 9, 2023 13:57

k1rill linked an issue Nov 9, 2023 that may be closed by this pull request

[Android] Social Login and Authentication #72

Closed

farhan-arshad-dev requested changes Nov 13, 2023

View reviewed changes

k1rill force-pushed the feature/social_login branch 4 times, most recently from c4abc04 to bfb58db Compare November 14, 2023 18:23

k1rill requested a review from farhan-arshad-dev November 15, 2023 11:08

marcotuts mentioned this pull request Nov 15, 2023

[Android] Pre-Login Mobile App Exploration #93

Closed

nizmaylova mentioned this pull request Nov 16, 2023

[Android] Social Login and Authentication #72

Closed

k1rill force-pushed the feature/social_login branch from 46e8bca to f4bd187 Compare November 16, 2023 17:04

k1rill force-pushed the feature/social_login branch from b9aae4b to b094567 Compare November 17, 2023 12:42

volodymyr-chekyrta previously approved these changes Nov 20, 2023

View reviewed changes

omerhabib26 self-requested a review November 27, 2023 08:46

omerhabib26 requested changes Nov 29, 2023

View reviewed changes

farhan-arshad-dev reviewed Dec 4, 2023

View reviewed changes

k1rill dismissed volodymyr-chekyrta’s stale review via 5729be9 December 4, 2023 14:30

k1rill force-pushed the feature/social_login branch 9 times, most recently from 6f73afc to 7ebb9c0 Compare December 4, 2023 20:09

k1rill added 6 commits December 4, 2023 23:13

feat: login with Google, Facebook, Microsoft

748a660

fix: crash on social login

d6f52f3

refactor: moved auth helpers out of singletons

c89abb6

fix: generateMockedRawFile task running from direct task run only

b7c129b

refactor: applied new configuration management

db58788

feat: login with Google, Facebook, Microsoft

d9abb77

k1rill force-pushed the feature/social_login branch from 7ebb9c0 to d9abb77 Compare December 4, 2023 20:14

refactor: changes in colors and variables renaming

8efc553

farhan-arshad-dev requested changes Dec 7, 2023

View reviewed changes

refactor: configuration updates

8cb7016

k1rill requested a review from farhan-arshad-dev December 7, 2023 21:21

fix: updated SignInViewModelTest

01c68ac

miankhalid approved these changes Dec 11, 2023

View reviewed changes

volodymyr-chekyrta approved these changes Dec 11, 2023

View reviewed changes

volodymyr-chekyrta merged commit 73ed462 into openedx:develop Dec 11, 2023
3 checks passed

k1rill mentioned this pull request Feb 11, 2024

Social signup #208

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: login with Google, Facebook, Microsoft #89

feat: login with Google, Facebook, Microsoft #89

k1rill commented Nov 9, 2023 •

edited

Loading

farhan-arshad-dev Nov 13, 2023

k1rill Nov 14, 2023

farhan-arshad-dev commented Nov 14, 2023

k1rill commented Nov 15, 2023

volodymyr-chekyrta commented Nov 16, 2023

volodymyr-chekyrta commented Nov 24, 2023

omerhabib26 left a comment

farhan-arshad-dev left a comment

farhan-arshad-dev left a comment

farhan-arshad-dev Dec 5, 2023

k1rill Dec 7, 2023

farhan-arshad-dev Dec 7, 2023

k1rill Dec 7, 2023

farhan-arshad-dev Dec 7, 2023

k1rill Dec 7, 2023

farhan-arshad-dev Dec 7, 2023

k1rill Dec 7, 2023

miankhalid left a comment •

edited

Loading

feat: login with Google, Facebook, Microsoft #89

feat: login with Google, Facebook, Microsoft #89

Conversation

k1rill commented Nov 9, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

farhan-arshad-dev commented Nov 14, 2023

k1rill commented Nov 15, 2023

volodymyr-chekyrta commented Nov 16, 2023

volodymyr-chekyrta commented Nov 24, 2023

omerhabib26 left a comment

Choose a reason for hiding this comment

farhan-arshad-dev left a comment

Choose a reason for hiding this comment

farhan-arshad-dev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miankhalid left a comment • edited Loading

Choose a reason for hiding this comment

k1rill commented Nov 9, 2023 •

edited

Loading

miankhalid left a comment •

edited

Loading