feat: pre-login mobile app exploration #86

omerhabib26 · 2023-11-06T14:49:44Z

Description
This PR adds support for pre-login exploration.

Feature is implemented behind a feature flag preLoginExperienceEnabled
User will be able to navigate to Signup, SignIn, DiscoveryCourses & SearchCourses screen
Back button is added on required screens for back navigation
Navigation from SignIn to Signup is removed
Screen Orientation supported

Here is the video of the implemented feature

prelogin-experience.mp4

farhan-arshad-dev · 2023-11-13T09:09:07Z

config.yaml

+#feature flag for activating pre_login experience
+preLoginExperienceEnabled: true


Most of the configurations are in SCREAMING_SNAKE_CASE better to adopt.

We should decide on the standards first as the above mentioned flags are also written in CAMEL_CASE

@volodymyr-chekyrta thoughts?

farhan-arshad-dev · 2023-11-13T09:20:52Z

app/src/main/java/org/openedx/app/AppActivity.kt

+                    when {
+                        org.openedx.core.BuildConfig.PRE_LOGIN_EXPERIENCE_ENABLED ->
+                            addFragment(PreAuthFragment())
+
+                        else -> addFragment(SignInFragment())
+                    }
                }
+
+                shouldShowWhatsNew() -> addFragment(WhatsNewFragment())
+                corePreferencesManager.user != null -> addFragment(MainFragment())


IMO, better to wrap all the cases with {} even for the single liners, to make the code format consistent.

farhan-arshad-dev · 2023-11-13T09:23:00Z

app/src/main/java/org/openedx/app/AppActivity.kt

+                    when {
+                        org.openedx.core.BuildConfig.PRE_LOGIN_EXPERIENCE_ENABLED ->
+                            addFragment(PreAuthFragment())
+
+                        else -> addFragment(SignInFragment())
+                    }


currently only have binary conditions so better to use if-else.

farhan-arshad-dev · 2023-11-13T10:17:05Z

auth/src/main/java/org/openedx/auth/presentation/preAuth/PreAuthFragment.kt

+                        searchValue = textFieldValue,
+                        keyboardActions = {
+                            focusManager.clearFocus()
+                            onSearchClick(textFieldValue.text)


The learner should navigate to CourseSearchFragment directly when the user clicks the search button.

Also, there is the infinite search progress on CourseSearchFragment.

Let us decide as there is no decision on how we gonna handle the backstack.

As decided in the meeting current flow is expected.

farhan-arshad-dev · 2023-11-13T10:20:10Z

auth/src/main/java/org/openedx/auth/presentation/preAuth/PreAuthFragment.kt

+private fun PreLoginScreen(
+    onSearchClick: (query: String) -> Unit,
+    onRegisterClick: () -> Unit,
+    onLoginClick: () -> Unit,


IMO, onSigninClick is more appropriate here.

farhan-arshad-dev · 2023-11-13T10:28:07Z

auth/src/main/java/org/openedx/auth/presentation/signin/SignInFragment.kt

+            if (BuildConfig.PRE_LOGIN_EXPERIENCE_ENABLED.not()) {
+                Text(
+                    modifier = Modifier.noRippleClickable {
+                        onRegisterClick()
+                    },
+                    text = stringResource(id = R.string.auth_register),
+                    color = MaterialTheme.appColors.primary,
+                    style = MaterialTheme.appTypography.labelLarge
+                )
+            }


IMO, we can revert this to allow the learner to navigate to Registration screen from Signin screen.

It was part of the ticket scope

farhan-arshad-dev · 2023-11-13T10:31:28Z

auth/src/main/res/values/strings.xml

@@ -1,5 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
-<resources>
+<resources xmlns:tools="http://schemas.android.com/tools">
+    <string name="pre_auth_title" tools:ignore="ExtraTranslation">Courses and Programs from the world\'s best universities in your pocket.</string>


P should be in the small letter to match with the production.

farhan-arshad-dev · 2023-11-13T10:38:37Z

discovery/src/main/java/org/openedx/discovery/presentation/DiscoveryFragment.kt

+                LaunchedEffect(key1 = uiState) {
+                    if (querySearch.isNotEmpty()) {
+                        router.navigateToCourseSearch(
+                            requireActivity().supportFragmentManager, querySearch
+                        )
+                        arguments?.let {
+                            it.putString(ARG_SEARCH_QUERY, "")
+                        }
+                    }
+                }


no need once the learner directly navigates to search course screen.

current flow is good for now.

farhan-arshad-dev · 2023-11-13T10:46:01Z

discovery/src/main/java/org/openedx/discovery/presentation/search/CourseSearchFragment.kt

+                LaunchedEffect(key1 = uiState) {
+                    viewModel.search(querySearch)
+                }


this might be the cause of infinite progress.

farhan-arshad-dev · 2023-11-13T10:50:04Z

discovery/src/main/java/org/openedx/discovery/presentation/search/CourseSearchFragment.kt

+import androidx.compose.foundation.layout.Arrangement
+import androidx.compose.foundation.layout.Box
+import androidx.compose.foundation.layout.Column
+import androidx.compose.foundation.layout.PaddingValues
+import androidx.compose.foundation.layout.Spacer
+import androidx.compose.foundation.layout.fillMaxSize
+import androidx.compose.foundation.layout.fillMaxWidth
+import androidx.compose.foundation.layout.height
+import androidx.compose.foundation.layout.navigationBarsPadding
+import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.layout.width
+import androidx.compose.foundation.layout.widthIn


IMO, we should decide coding standards for the repo, to reduce such optimizations and code changes.
thoughts @volodymyr-chekyrta, @k1rill, @HamzaIsrar12

IMO, better to go with the default studio Formatter | Linter. Open for suggestions.

volodymyr-chekyrta · 2023-11-13T11:55:08Z

Agree with the feedback provided by @farhan-arshad-dev.
It would be beneficial to address those concerns before moving forward.

farhan-arshad-dev · 2023-11-14T09:00:31Z

auth/src/main/java/org/openedx/auth/presentation/preAuth/PreAuthFragment.kt

+                    contentDescription = null,
+                    modifier = Modifier
+                        .padding(top = 32.dp, bottom = 32.dp)
+                        .width(170.dp)


batter to update with .wrapContentWidth().

farhan-arshad-dev · 2023-11-14T09:03:28Z

auth/src/main/java/org/openedx/auth/presentation/preAuth/PreAuthFragment.kt

+                    painter = painterResource(id = org.openedx.core.R.drawable.core_ic_logo),
+                    contentDescription = null,
+                    modifier = Modifier
+                        .padding(top = 32.dp, bottom = 32.dp)


The top space should be 90dp in total, to match with the production.

The bottom space should be 20dp in total, to match with the production.

farhan-arshad-dev · 2023-11-14T09:06:17Z

auth/src/main/java/org/openedx/auth/presentation/preAuth/PreAuthFragment.kt

+                    text = stringResource(id = R.string.pre_auth_title),
+                    color = MaterialTheme.appColors.textPrimary,
+                    style = MaterialTheme.appTypography.headlineSmall,
+                    modifier = Modifier.padding(bottom = 32.dp)


The bottom space should be 40dp in total, to match with the production.

farhan-arshad-dev · 2023-11-14T09:09:56Z

auth/src/main/java/org/openedx/auth/presentation/preAuth/PreAuthFragment.kt

+                        style = MaterialTheme.appTypography.titleMedium,
+                        text = stringResource(id = R.string.pre_auth_search_title),
+                    )
+                    SearchBar(


bottom space should be 10dp in total.

farhan-arshad-dev · 2023-11-14T09:13:06Z

auth/src/main/java/org/openedx/auth/presentation/preAuth/PreAuthFragment.kt

+@Preview(uiMode = Configuration.UI_MODE_NIGHT_NO)
+@Preview(uiMode = Configuration.UI_MODE_NIGHT_YES)
+@Composable
+private fun SignInScreenPreview() {


better to add the preview for Landscape|Tablet mode.

Preview added for Tablet Mode, no need for landscape mode.

farhan-arshad-dev

Some concerns for @volodymyr-chekyrta, and some code-related nits, other than that LGTM.

farhan-arshad-dev · 2023-11-15T09:58:10Z

discovery/src/main/java/org/openedx/discovery/presentation/DiscoveryFragment.kt

@@ -183,6 +211,21 @@ internal fun DiscoveryScreen(

        HandleUIMessage(uiMessage = uiMessage, scaffoldState = scaffoldState)

+        if (BuildConfig.PRE_LOGIN_EXPERIENCE_ENABLED) {


Also need to check user is not null, otherwise app shows the back button on the Maindashboard screen.

farhan-arshad-dev · 2023-11-15T10:02:52Z

app/src/main/java/org/openedx/app/AppActivity.kt

+                    when {
+                        org.openedx.core.BuildConfig.PRE_LOGIN_EXPERIENCE_ENABLED ->
+                            addFragment(PreAuthFragment())
+
+                        else -> addFragment(SignInFragment())
+                    }
                }
+
+                shouldShowWhatsNew() -> addFragment(WhatsNewFragment())
+                corePreferencesManager.user != null -> addFragment(MainFragment())


farhan-arshad-dev · 2023-11-15T10:07:13Z

discovery/src/main/java/org/openedx/discovery/presentation/search/CourseSearchFragment.kt

@@ -379,6 +376,10 @@ private fun CourseSearchScreen(
            }
        }
    }
+    var isPageLoaded = rememberSaveable { true }


replace with val

farhan-arshad-dev · 2023-11-15T10:12:38Z

auth/src/main/java/org/openedx/auth/presentation/preAuth/PreAuthFragment.kt

+import org.openedx.core.ui.theme.appColors
+import org.openedx.core.ui.theme.appTypography
+
+class PreAuthFragment : Fragment() {


Previously we called this screen Logistration, IMO, better to update the package, and class name accordingly.

auth/src/main/java/org/openedx/auth/presentation/preAuth/PreAuthFragment.kt

discovery/src/main/java/org/openedx/discovery/presentation/DiscoveryFragment.kt

volodymyr-chekyrta · 2023-11-24T09:37:17Z

@k1rill @farhan-arshad-dev @HamzaIsrar12,
let's focus on this PR, waiting for your review/approval.

app/src/main/java/org/openedx/app/AppActivity.kt

k1rill · 2023-11-24T09:48:48Z

auth/src/main/java/org/openedx/auth/presentation/logistration/Logistration.kt

+
+@Composable
+private fun PreLoginScreen(
+    onSearchClick: (query: String) -> Unit,


it's better to use sealed interface here for example:

sealed interface OnClick { data class Search(query: String): OnClick object Registration: OnClick .... }

Currently, we are not following the mentioned approach.
@volodymyr-chekyrta your thoughts on this?

will leave this as nit

auth/src/main/java/org/openedx/auth/presentation/logistration/Logistration.kt

k1rill · 2023-11-24T09:58:35Z

auth/src/main/java/org/openedx/auth/presentation/signin/SignInFragment.kt

@@ -197,7 +203,21 @@ private fun LoginScreen(
            uiMessage = uiMessage,
            scaffoldState = scaffoldState
        )
-
+        if (BuildConfig.PRE_LOGIN_EXPERIENCE_ENABLED) {


It's better to move config out of UI, for example in the UI state and init it in viewModel

Hey @k1rill, we can do that but in my opinion, are there any benefits to taking such a long route for a single flag? is there inspiration or reference available?

@omerhabib26 we are trying to build Clean architecture with SOLID principles. UI shouldn't work with logic directly. Config can't be changed runtime at this moment, so we should init it once on the ViewModel init. Also when the new configuration will be merged, we have to update this code, it's better to update it once inside viewModel, instead of searching all entries. Much easier to make this route long while development, than to change it a lot of times while maintaining the code

k1rill · 2023-11-26T09:29:26Z

auth/src/main/java/org/openedx/auth/presentation/logistration/Logistration.kt

+@Preview(name = "NEXUS_9_Light", device = Devices.NEXUS_9, uiMode = Configuration.UI_MODE_NIGHT_NO)
+@Preview(name = "NEXUS_9_Night", device = Devices.NEXUS_9, uiMode = Configuration.UI_MODE_NIGHT_YES)
+@Composable
+private fun SignInScreenPreview() {


Please rename SignInScreen. nit: Also there are 2 different names on this screen, fragment is called Logistration, and main Composable is called PreLoginScreen

omerhabib26 · 2023-11-27T12:19:33Z

@k1rill ready for another pass

k1rill

@omerhabib26 good job!

omerhabib26 · 2023-11-28T10:41:44Z

@volodymyr-chekyrta the PR is approved now you can merge it. 🚀

farhan-arshad-dev · 2023-11-30T10:37:32Z

auth/src/main/java/org/openedx/auth/presentation/signin/SignInViewModel.kt

@@ -44,7 +45,11 @@ class SignInViewModel(
    val appUpgradeEvent: LiveData<AppUpgradeEvent>
        get() = _appUpgradeEvent

+    private val _isLogistrationEnabled = SingleEventLiveData<Boolean>()


SingleEventLiveData leads to the app crash, better to update with MutableLiveData.

farhan-arshad-dev · 2023-11-30T10:43:03Z

discovery/src/main/java/org/openedx/discovery/presentation/DiscoveryFragment.kt

@@ -110,10 +117,34 @@ class DiscoveryFragment : Fragment() {
                            requireParentFragment().parentFragmentManager,


The following steps lead to the app crash.

Open the app user redirect to the Logistration screen.

Click on the Explore all courses redirect to the Discover screen.

Click on the course card, 💥 app crashed.

It was not the part of the ticket scope but I have fixed it

farhan-arshad-dev · 2023-11-30T10:44:36Z

discovery/src/main/java/org/openedx/discovery/presentation/DiscoveryViewModel.kt

@@ -46,6 +47,9 @@ class DiscoveryViewModel(
    val appUpgradeEvent: LiveData<AppUpgradeEvent>
        get() = _appUpgradeEvent

+    private val _isLogistrationEnabled = SingleEventLiveData<Boolean>()


SingleEventLiveData leads to the app crash at some point.

volodymyr-chekyrta · 2023-11-30T11:13:48Z

@omerhabib26, I found one problem, could you please check why it is crashing?
The video is attached below.
https://github.com/openedx/openedx-app-android/assets/127732735/26e61930-5179-4912-a2ca-d318a02b2774

volodymyr-chekyrta · 2023-11-30T11:16:06Z

Also, there is a crash when trying to open any course.
java.lang.IllegalStateException: Fragment DiscoveryFragment{a096e35} (d8cc59a3-8b4b-4a42-9f65-50d120962281 id=0x7f0a00b8 tag=DiscoveryFragment) is not a child Fragment, it is directly attached to org.openedx.app.AppActivity@c8a8e38
https://github.com/openedx/openedx-app-android/assets/127732735/6524ad19-a10d-417a-9ba2-a11d1a045879

volodymyr-chekyrta · 2023-11-30T11:20:55Z

Same problem as in iOS - the user sees an error message when trying to enroll.
Perhaps should redirect the user to log in or hide the "Enroll" button.

omerhabib26 · 2023-11-30T13:02:47Z

Same problem as in iOS - the user sees an error message when trying to enroll. Perhaps should redirect the user to log in or hide the "Enroll" button.

This is a known behavior and is not a part of the ticket scope.

farhan-arshad-dev

Just an improvement, other than that looks good to me.

farhan-arshad-dev · 2023-12-01T07:42:16Z

discovery/src/main/java/org/openedx/discovery/presentation/DiscoveryFragment.kt

+                val isLogistrationEnabled by viewModel.isLogistrationEnabled.observeAsState(false)
+                val canShowBackButton = isLogistrationEnabled && corePreferencesManager.user == null


There is no other use of corePreferencesManager so better to move inside the DiscoveryViewModel.

volodymyr-chekyrta · 2023-12-04T09:52:04Z

auth/src/main/java/org/openedx/auth/presentation/logistration/Logistration.kt

+import org.openedx.core.ui.theme.appColors
+import org.openedx.core.ui.theme.appTypography
+
+class Logistration : Fragment() {


To keep consistency with other fragments, it would be great to rename it to LogistrationFragment.
Same to the file name.

volodymyr-chekyrta · 2023-12-04T09:53:58Z

No other issues; we can merge it after renaming the Logistration file and resolving conflicts.

- Feature is implemented behind a feature flag `preLoginExperienceEnabled` - User will be able to navigate to Signup, Signin, DiscoveryCourses & SearchCourses screen - Back button is added on required screens for back navigation - Navigation from SignIn to Signup is removed fix: LEARNER-9663

…ture

omerhabib26 · 2023-12-04T11:26:33Z

@volodymyr-chekyrta @k1rill @farhan-arshad-dev PR is updated according to the new Config architecture. please have a look

volodymyr-chekyrta

LGTM 🚀

farhan-arshad-dev

Some Nits
No need file config.yaml, can be deleted.

After that, I'll approve the PR.

farhan-arshad-dev · 2023-12-04T12:14:05Z

auth/src/main/java/org/openedx/auth/presentation/signin/SignInViewModel.kt

+    private val _isLogistrationEnabled = MutableLiveData<Boolean>()
+    val isLogistrationEnabled: LiveData<Boolean> = _isLogistrationEnabled


better to replace this with the getter.

farhan-arshad-dev · 2023-12-04T12:14:37Z

core/src/main/java/org/openedx/core/config/Config.kt

@@ -51,6 +50,10 @@ class Config(context: Context) {
        return getBoolean(WHATS_NEW_ENABLED, false)
    }

+    fun isPreLoginExperienceEnabled(): Boolean {
+        return getBoolean(PRE_LOGIN_EXPERIENCE_ENABLED, true)


better to change the default value with false.

* feat: pre-login mobile app exploration - Feature is implemented behind a feature flag `preLoginExperienceEnabled` - User will be able to navigate to Signup, Signin, DiscoveryCourses & SearchCourses screen - Back button is added on required screens for back navigation - Navigation from SignIn to Signup is removed fix: LEARNER-9663 * fix: Address PR comments * fix: Address PR comments - 2 * fix: Address PR comments * fix: resolve test cases * fix: Address PR comments + crash fix * fix: App crash on Discovery Fragment * fix: small code improvement * fix: Resolve conflicts + Update code according to new config architecture * fix: addressed minor nits

omerhabib26 force-pushed the omer/LEARNER-9663 branch from 6fb0f0c to a5a678f Compare November 6, 2023 14:58

omerhabib26 requested review from volodymyr-chekyrta, k1rill, farhan-arshad-dev and HamzaIsrar12 November 6, 2023 15:44

miankhalid mentioned this pull request Nov 13, 2023

[iOS] Pre-Login Mobile App Exploration openedx/openedx-app-ios#109

Open

farhan-arshad-dev requested changes Nov 13, 2023

View reviewed changes

farhan-arshad-dev requested changes Nov 14, 2023

View reviewed changes

farhan-arshad-dev requested changes Nov 15, 2023

View reviewed changes

k1rill reviewed Nov 15, 2023

View reviewed changes

auth/src/main/java/org/openedx/auth/presentation/preAuth/PreAuthFragment.kt Outdated Show resolved Hide resolved

k1rill requested changes Nov 15, 2023

View reviewed changes

auth/src/main/java/org/openedx/auth/presentation/preAuth/PreAuthFragment.kt Outdated Show resolved Hide resolved

discovery/src/main/java/org/openedx/discovery/presentation/DiscoveryFragment.kt Outdated Show resolved Hide resolved

marcotuts mentioned this pull request Nov 15, 2023

[Android] Pre-Login Mobile App Exploration #93

Closed

volodymyr-chekyrta mentioned this pull request Nov 17, 2023

feat: pre-login mobile app exploration openedx/openedx-app-ios#139

Merged

k1rill reviewed Nov 24, 2023

View reviewed changes

omerhabib26 force-pushed the omer/LEARNER-9663 branch from 9d75c21 to ed996b5 Compare November 24, 2023 20:19

k1rill self-requested a review November 26, 2023 09:25

k1rill reviewed Nov 26, 2023

View reviewed changes

k1rill self-requested a review November 26, 2023 09:31

k1rill previously approved these changes Nov 28, 2023

View reviewed changes

farhan-arshad-dev requested changes Nov 30, 2023

View reviewed changes

omerhabib26 dismissed k1rill’s stale review via 6a42e9c November 30, 2023 13:16

omerhabib26 force-pushed the omer/LEARNER-9663 branch from 4229af3 to 6a42e9c Compare November 30, 2023 13:16

farhan-arshad-dev requested changes Dec 1, 2023

View reviewed changes

omerhabib26 requested a review from farhan-arshad-dev December 1, 2023 18:43

farhan-arshad-dev approved these changes Dec 2, 2023

View reviewed changes

volodymyr-chekyrta previously approved these changes Dec 2, 2023

View reviewed changes

volodymyr-chekyrta reviewed Dec 4, 2023

View reviewed changes

omerhabib26 added 8 commits December 4, 2023 15:01

fix: Address PR comments

8d47e4d

fix: Address PR comments - 2

f7917a7

fix: Address PR comments

7f852f2

fix: resolve test cases

ebff6d7

fix: Address PR comments + crash fix

eaf71dc

fix: App crash on Discovery Fragment

d1d52ca

fix: small code improvement

50f3a35

omerhabib26 dismissed volodymyr-chekyrta’s stale review via 50f3a35 December 4, 2023 10:08

omerhabib26 force-pushed the omer/LEARNER-9663 branch from 749464a to 50f3a35 Compare December 4, 2023 10:08

fix: Resolve conflicts + Update code according to new config architec…

8475240

…ture

omerhabib26 requested review from farhan-arshad-dev and volodymyr-chekyrta December 4, 2023 11:25

volodymyr-chekyrta previously approved these changes Dec 4, 2023

View reviewed changes

farhan-arshad-dev requested changes Dec 4, 2023

View reviewed changes

omerhabib26 dismissed volodymyr-chekyrta’s stale review via 67a160b December 4, 2023 12:50

fix: addressed minor nits

67a160b

farhan-arshad-dev approved these changes Dec 4, 2023

View reviewed changes

volodymyr-chekyrta approved these changes Dec 4, 2023

View reviewed changes

volodymyr-chekyrta merged commit 44f4d2d into openedx:develop Dec 4, 2023
2 checks passed

omerhabib26 deleted the omer/LEARNER-9663 branch December 4, 2023 14:02

miankhalid linked an issue Dec 12, 2023 that may be closed by this pull request

[Android] Pre-Login Mobile App Exploration #93

Closed

		#feature flag for activating pre_login experience
		preLoginExperienceEnabled: true

		@@ -183,6 +211,21 @@ internal fun DiscoveryScreen(

		HandleUIMessage(uiMessage = uiMessage, scaffoldState = scaffoldState)

		if (BuildConfig.PRE_LOGIN_EXPERIENCE_ENABLED) {

		@@ -110,10 +117,34 @@ class DiscoveryFragment : Fragment() {
		requireParentFragment().parentFragmentManager,

		val isLogistrationEnabled by viewModel.isLogistrationEnabled.observeAsState(false)
		val canShowBackButton = isLogistrationEnabled && corePreferencesManager.user == null

		private val _isLogistrationEnabled = MutableLiveData<Boolean>()
		val isLogistrationEnabled: LiveData<Boolean> = _isLogistrationEnabled

feat: pre-login mobile app exploration #86

feat: pre-login mobile app exploration #86

Conversation

omerhabib26 commented Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

volodymyr-chekyrta commented Nov 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

farhan-arshad-dev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

volodymyr-chekyrta commented Nov 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

omerhabib26 commented Nov 27, 2023

k1rill left a comment

Choose a reason for hiding this comment

omerhabib26 commented Nov 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

volodymyr-chekyrta commented Nov 30, 2023

volodymyr-chekyrta commented Nov 30, 2023

volodymyr-chekyrta commented Nov 30, 2023

omerhabib26 commented Nov 30, 2023

farhan-arshad-dev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

volodymyr-chekyrta commented Dec 4, 2023

omerhabib26 commented Dec 4, 2023

volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

farhan-arshad-dev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

omerhabib26 commented Nov 6, 2023 •

edited

Loading