Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gson proguard rules fix #64

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

PavloNetrebchuk
Copy link
Contributor

Keep classes that will be serialized/deserialized over Gson in proguard-rules.pro

@volodymyr-chekyrta volodymyr-chekyrta merged commit 65fa1f8 into openedx:develop Sep 29, 2023
@volodymyr-chekyrta volodymyr-chekyrta deleted the bugfix/gson_crash branch September 29, 2023 09:05
k1rill pushed a commit to touchapp/openedx-app-android that referenced this pull request Dec 11, 2024
…edx#64)

- Update Media3 library to version 1.4.1
- Remove custom HLSMediaSource in favor of DefaultMediaSource
- Add the CC Button in the ExoPlayer view
- Pass transcripts to VideoFullScreenFragment
- Configure MediaItem with subtitles
- Retain subtitle on configuration change
- Sort the subtitle listing in the ExoPlayer
- Update the video DownloadModel to include transcripts
- Download transcripts along with videos for offline mode
- Make the feature compatible with external subtitles
- Remove transcripts on removing video

Fixes: LEARNER-10259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants