feat: add flag to remove registration from app #387
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @kaustavb12! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| isRegistrationEnabled = false, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add a new line to the end of the file
| @@ -244,7 +244,7 @@ private fun AuthForm( | |||
| .fillMaxWidth() | |||
| .padding(top = 20.dp, bottom = 36.dp) | |||
| ) { | |||
| if (state.isLogistrationEnabled.not()) { | |||
| if (state.isLogistrationEnabled.not() and state.isRegistrationEnabled) { | |||
There was a problem hiding this comment.
Please change and to && to keep style consistency.
|
@volodymyr-chekyrta Thanks a lot for the review. I have addressed both the feedback points, please take a look. |
@kaustavb12, Looks good to me 👍 Thank you! |
kaustavb12
force-pushed
the
kaustav/remove_register_button_upstream
branch
from
bbec96c to
17130c4
Compare
|
Target changed to develop, rebased and squashed. Please take a look. |
|
@volodymyr-chekyrta Thanks a lot for your help with review and merge. |
Description
Some OpenedX operators want user registration disabled from their UIs, so that user registration can be operated through the APIs, from external applications like salesforce. Currently we don't have such an option for this android app.
This PR adds a flag called
REGISTRATION_ENABLEDwhich controls if Registration option is displayed to users.Testing instructions
REGISTRATION_ENABLEDtotruein config and verify Registration button/link is visible.REGISTRATION_ENABLEDtofalsein config and verify Registration button/link is gone.Other information
Private Ref : BB-9186