Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore IllegalStateException when fragment transaction fails #373

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: ignore IllegalStateException when fragment transaction fails #373

merged 1 commit into from
Oct 7, 2024

Conversation

dixidroid
Copy link
Contributor

Added ability to ignore crash when we try to add a fragment at the wrong time. This doesn't affect anything and works when the app in the background state.

volodymyr-chekyrta
volodymyr-chekyrta approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
It would be great to understand the root cause of this crash, what part of the application is trying to perform transition on the background.

@volodymyr-chekyrta volodymyr-chekyrta merged commit 42f5835 into openedx:develop Oct 7, 2024
4 checks passed
@PavloNetrebchuk PavloNetrebchuk mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dixidroid @volodymyr-chekyrta