-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: validate plurals in strings.xml | FC-55 #348
chore: validate plurals in strings.xml | FC-55 #348
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
db17b43
to
5818881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
5818881
to
ff3e51c
Compare
ff3e51c
to
d8a2011
Compare
Thanks @volodymyr-chekyrta for the quick review. Kindly merge that the new fix commit has been pushed. |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Plurals are failing the transifex import. I've fixed them manually in #341, but more are coming. Therefore a GitHub Actions is needed.
Testing
Example failure:
The second commit fixes those failures and the CI passes correctly.