fix: removed extra space on the course tab #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewing |
omerhabib26
reviewed
Mar 27, 2024
| @@ -392,11 +389,19 @@ internal fun CourseOutlineScreen( | |||
| Box(listPadding) { | |||
| if (windowSize.isTablet) { | |||
| ResumeCourseTablet( | |||
| modifier = Modifier.padding( | |||
| top = 16.dp, | |||
There was a problem hiding this comment.
we can use vertical instead of top & bottom
omerhabib26
reviewed
Mar 27, 2024
| block = uiState.resumeComponent, | ||
| onResumeClick = onResumeClick | ||
| ) | ||
| } else { | ||
| ResumeCourse( | ||
| modifier = Modifier.padding( |
dixidroid
force-pushed
the
fix/empty_space_in_course_tab
branch
from
3d77c38 to
9d80dba
Compare
omerhabib26
approved these changes
Mar 27, 2024
volodymyr-chekyrta
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed extra space on the course tab in different scenarios like: with/without new design, with/without resume button, with/without Dates banner.