feat: Text and icons adjustment #266

PavloNetrebchuk · 2024-03-21T12:36:15Z

Changes according to this document:
https://www.figma.com/file/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?type=design&node-id=9980-2&mode=design&t=m8EjlsKk0aI9cQe8-0

openedx-webhooks · 2024-03-21T12:36:20Z

Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

sdaitzman · 2024-03-25T14:35:24Z

I did find one minor phrasing change I would recommend: “Log out” over “Logout” for consistency with the rest of the app, as well as the web version. Everything else looks good to me!

PavloNetrebchuk · 2024-03-25T15:35:18Z

@sdaitzman

Done

omerhabib26

Some minor code changes and improvements

omerhabib26 · 2024-03-26T07:29:54Z

core/src/main/res/values/strings.xml

@@ -73,7 +73,8 @@
    <string name="core_rate_us">Rate Us</string>
    <string name="core_thank_you_dialog_positive_description">Thank you for sharing your feedback with us. Would you like to share your review of this app with other users on the app store?</string>
    <string name="core_thank_you_dialog_negative_description">We received your feedback and will use it to help improve your learning experience going forward. Thank you for sharing!</string>
-    <string name="core_not_connected_to_internet">You are not connected to the Internet. Please check your Internet connection.</string>
+    <string name="core_not_internet_connection">No internet connection</string>


Can we rename it to core_no_internet_connection?

omerhabib26 · 2024-03-26T07:30:07Z

core/src/main/res/values/strings.xml

@@ -73,7 +73,8 @@
    <string name="core_rate_us">Rate Us</string>
    <string name="core_thank_you_dialog_positive_description">Thank you for sharing your feedback with us. Would you like to share your review of this app with other users on the app store?</string>
    <string name="core_thank_you_dialog_negative_description">We received your feedback and will use it to help improve your learning experience going forward. Thank you for sharing!</string>
-    <string name="core_not_connected_to_internet">You are not connected to the Internet. Please check your Internet connection.</string>
+    <string name="core_not_internet_connection">No internet connection</string>
+    <string name="core_not_internet_connection_description">Please connect to the internet to view this content.</string>


omerhabib26 · 2024-03-26T07:32:36Z

course/src/main/res/values/strings.xml

    <string name="course_not_started">This course hasn’t started yet.</string>
    <string name="course_not_connected_to_internet">You are not connected to the Internet. Please check your Internet connection.</string>
    <string name="course_navigation_course">Course</string>
    <string name="course_navigation_videos">Videos</string>
    <string name="course_navigation_discussions">Discussions</string>
-    <string name="course_navigation_handouts">Handouts</string>
+    <string name="course_navigation_more">More</string>


Can we use a generic string for both?
1- More
2- More

omerhabib26 · 2024-03-26T07:33:34Z

course/src/main/res/values/strings.xml

    <string name="course_can_download_only_with_wifi">You can download content only from Wi-fi</string>
-    <string name="course_this_interactive_component">This interactive component isn’t yet available</string>
+    <string name="course_this_interactive_component">This interactive component isn\'t available on mobile</string>


please add a full stop at the end of the sentence.

omerhabib26 · 2024-03-26T07:34:01Z

dashboard/src/main/res/values-uk/strings.xml

@@ -3,6 +3,5 @@
    <string name="dashboard_title">Мої курси</string>
    <string name="dashboard_courses">Курси</string>
    <string name="dashboard_welcome_back">Ласкаво просимо назад. Продовжуймо навчатися.</string>
-    <string name="dashboard_its_empty">It\'s empty</string>
    <string name="dashboard_you_are_not_enrolled">You are not enrolled in any courses yet.</string>
 </resources>


Please add a blank line at EOF.

omerhabib26 · 2024-03-26T11:01:50Z

core/src/main/res/drawable/core_ic_close.xml

@@ -0,0 +1,24 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"


we can remove this and use imageVector = Icons.Filled.Close,

omerhabib26 · 2024-03-26T11:02:53Z

core/src/main/res/drawable/core_no_internet_connection.xml

@@ -0,0 +1,9 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"


requires auto-format.

omerhabib26 · 2024-03-26T11:05:19Z

core/src/main/res/drawable/core_ic_reload.xml

@@ -0,0 +1,24 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"


1- can we use white color as a strokeColor to make it more generic?
2- requires auto-format

omerhabib26 · 2024-03-26T11:06:03Z

core/src/main/res/drawable/core_ic_offline.xml

@@ -0,0 +1,45 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"


1- can we use white color as a strokeColor to make it more generic?
2- requires auto-format

omerhabib26 · 2024-03-26T11:07:41Z

course/src/main/res/drawable/course_ic_not_supported_block.xml

@@ -3,21 +3,6 @@
    android:height="100dp"


1- can we use white color as a strokeColor to make it more generic?
2- requires auto-format

PavloNetrebchuk · 2024-03-27T09:46:18Z

@omerhabib26 Changed and formatted👍

# Conflicts: # course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt

openedx-webhooks · 2024-03-27T14:32:51Z

@PavloNetrebchuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

PavloNetrebchuk added 3 commits March 20, 2024 13:20

feat: Profile UI changes

a1b4a6f

feat: Auth UI changes

62cc4f9

feat: Navigation UI changes

7617115

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 21, 2024

feat: Outline UI changes

bae55d2

PavloNetrebchuk force-pushed the feat/ui_changes branch from 723d41d to bae55d2 Compare March 21, 2024 12:41

volodymyr-chekyrta self-requested a review March 21, 2024 13:14

PavloNetrebchuk changed the title ~~feat: Minor UI changes~~ feat: Text and icons adjustment Mar 21, 2024

refactor: Created WarningLabel

320e237

PavloNetrebchuk marked this pull request as ready for review March 25, 2024 11:12

volodymyr-chekyrta previously approved these changes Mar 25, 2024

View reviewed changes

volodymyr-chekyrta requested a review from k1rill March 25, 2024 11:15

PavloNetrebchuk dismissed volodymyr-chekyrta’s stale review via 6dd3c45 March 25, 2024 15:18

PavloNetrebchuk added 2 commits March 25, 2024 17:29

fix: Strings fix ("Logout")

2cba71a

fix: Strings fix ("Logout")

92d5b6c

PavloNetrebchuk force-pushed the feat/ui_changes branch from 6dd3c45 to 92d5b6c Compare March 25, 2024 15:31

k1rill previously approved these changes Mar 26, 2024

View reviewed changes

omerhabib26 requested changes Mar 26, 2024

View reviewed changes

fix: String and color changes, files auto-formatting

f514c8b

PavloNetrebchuk dismissed k1rill’s stale review via f514c8b March 27, 2024 09:43

Merge remote-tracking branch 'origin/develop' into feat/ui_changes

8b1146f

omerhabib26 previously approved these changes Mar 27, 2024

View reviewed changes

Merge remote-tracking branch 'origin/develop' into feat/ui_changes

4416b3a

# Conflicts: # course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt

PavloNetrebchuk dismissed omerhabib26’s stale review via 4416b3a March 27, 2024 14:26

volodymyr-chekyrta approved these changes Mar 27, 2024

View reviewed changes

volodymyr-chekyrta merged commit f294057 into openedx:develop Mar 27, 2024
3 checks passed

volodymyr-chekyrta deleted the feat/ui_changes branch March 27, 2024 14:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Text and icons adjustment #266

feat: Text and icons adjustment #266

PavloNetrebchuk commented Mar 21, 2024 •

edited

Loading

openedx-webhooks commented Mar 21, 2024 •

edited

Loading

sdaitzman commented Mar 25, 2024

PavloNetrebchuk commented Mar 25, 2024

omerhabib26 left a comment

omerhabib26 Mar 26, 2024

omerhabib26 Mar 26, 2024

omerhabib26 Mar 26, 2024

omerhabib26 Mar 26, 2024

omerhabib26 Mar 26, 2024

omerhabib26 Mar 26, 2024

omerhabib26 Mar 26, 2024

omerhabib26 Mar 26, 2024

omerhabib26 Mar 26, 2024

omerhabib26 Mar 26, 2024

PavloNetrebchuk commented Mar 27, 2024

openedx-webhooks commented Mar 27, 2024

		@@ -0,0 +1,24 @@
		<vector xmlns:android="http://schemas.android.com/apk/res/android"

		@@ -0,0 +1,9 @@
		<vector xmlns:android="http://schemas.android.com/apk/res/android"

		@@ -0,0 +1,45 @@
		<vector xmlns:android="http://schemas.android.com/apk/res/android"

feat: Text and icons adjustment #266

feat: Text and icons adjustment #266

Conversation

PavloNetrebchuk commented Mar 21, 2024 • edited Loading

openedx-webhooks commented Mar 21, 2024 • edited Loading

sdaitzman commented Mar 25, 2024

PavloNetrebchuk commented Mar 25, 2024

omerhabib26 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PavloNetrebchuk commented Mar 27, 2024

openedx-webhooks commented Mar 27, 2024

PavloNetrebchuk commented Mar 21, 2024 •

edited

Loading

openedx-webhooks commented Mar 21, 2024 •

edited

Loading