style: Dates Tab Shift Due Dates Success SnackBar Design Changes #264
Conversation
fixes: LEARNER-9868
| @@ -8,5 +8,7 @@ sealed class UIMessage { | |||
| val duration: SnackbarDuration = SnackbarDuration.Long, | |||
| ) : UIMessage() | |||
|
|
|||
| class DatesShiftedSnackBar : UIMessage() | |||
There was a problem hiding this comment.
What if we relocate class DatesShiftedSnackBar: UIMessage() within the course module?
It appears unnecessary to inform the core module about Dates functionality.
There was a problem hiding this comment.
Inheritance of sealed classes or interfaces from different module is prohibited, to move Dates Shifted SnackBar into the course module need to make open instead of sealed.
thoughts?
There was a problem hiding this comment.
relocated.
| @Composable | ||
| fun DatesShiftedSnackBar( | ||
| showAction: Boolean = false, | ||
| onViewDates: () -> Unit? = {}, | ||
| onClose: () -> Unit? = {}, | ||
| ) { |
There was a problem hiding this comment.
Can be moved as well to the CourseUI.kt
| val snackState = remember { SnackbarHostState() } | ||
| if (uiMessage is UIMessage.DatesShiftedSnackBar) { | ||
| LaunchedEffect(uiMessage) { | ||
| snackState.showSnackbar(message = "Dates Shifted", duration = SnackbarDuration.Long) |
There was a problem hiding this comment.
Please move this text to resources
| val snackState = remember { SnackbarHostState() } | ||
| if (uiMessage is UIMessage.DatesShiftedSnackBar) { | ||
| LaunchedEffect(uiMessage) { | ||
| snackState.showSnackbar(message = "Dates Shifted", duration = SnackbarDuration.Long) |
There was a problem hiding this comment.
Please move this text to resources
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt
Outdated
Show resolved
Hide resolved
| modifier = Modifier | ||
| .padding(top = 4.dp) | ||
| .fillMaxWidth(), | ||
| text = stringResource(id = org.openedx.core.R.string.core_dates_shift_dates_successfully_msg), |
There was a problem hiding this comment.
please move org.openedx.core.R to import import org.openedx.core.R as CoreR
course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt
Outdated
Show resolved
Hide resolved
Description
Jira: LEARNER-9868
Github issue: [Android] Shift Dates (PLS) Design Changes