Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update project documentation #255

Conversation

volodymyr-chekyrta
Copy link
Contributor

This PR updates the project README file, introduces documentation on configuration management and APIs compatibility.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 7, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

k1rill
k1rill previously approved these changes Mar 11, 2024
Copy link
Contributor

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for leading this effort. 🚀 Document looks good overall, just a few minor issues and concerns I've noticed.

README.md Show resolved Hide resolved
Documentation/ConfigurationManagement.md Show resolved Hide resolved
- **Braze:** Could Messaging
- **SegmentIO:** Analytics

## Available Feature Flags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to mention other features like Agreement Urls, Discovery, Program etc? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel it's necessary to mention them now, since we store their default keys in the config.yaml file.
We can add documentation on them later.

Documentation/ConfigurationManagement.md Show resolved Hide resolved
Documentation/APIs_Compatibility.md Outdated Show resolved Hide resolved
@volodymyr-chekyrta volodymyr-chekyrta force-pushed the docs/update_project_documentation branch 2 times, most recently from 6f7910f to 498e61d Compare March 15, 2024 09:47
@volodymyr-chekyrta volodymyr-chekyrta force-pushed the docs/update_project_documentation branch from 498e61d to a61778d Compare March 15, 2024 09:49
@volodymyr-chekyrta
Copy link
Contributor Author

volodymyr-chekyrta commented Mar 15, 2024

@HamzaIsrar12 thank you for the review!
All feedback has been addressed, and PR is ready for another pass 🚀

@volodymyr-chekyrta volodymyr-chekyrta merged commit beedcb3 into openedx:develop Mar 18, 2024
3 checks passed
@openedx-webhooks
Copy link

@volodymyr-chekyrta 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@volodymyr-chekyrta volodymyr-chekyrta deleted the docs/update_project_documentation branch March 18, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants