Feat: Download all videos together #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixidroid
force-pushed
the
feat/all_videos_download
branch
from
fde4d8c to
655edf6
Compare
This was
linked to
issues
Feb 15, 2024
Comment on lines
83
to
87
| val title = stringResource( | ||
| id = if (viewModel.getQualityType() == VideoQualityType.Streaming) | ||
| R.string.core_video_streaming_quality else | ||
| R.string.core_video_download_quality | ||
| ) |
There was a problem hiding this comment.
Difficult to read construction.
Not required, but else could be moved to a separate line.
|
Not sure about moving |
course/src/main/java/org/openedx/course/presentation/videos/CourseVideosFragment.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/settings/download/DownloadQueueFragment.kt
Outdated
Show resolved
Hide resolved
volodymyr-chekyrta
approved these changes
Feb 23, 2024
k1rill
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to download all videos at once on the video tab.
Screen_Recording_20240215_103911_OpenEdX.mp4