-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Firebase config #233
feat: Firebase config #233
Conversation
Thanks for the pull request, @volodymyr-chekyrta! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
04aeaf4
to
dc67ef4
Compare
I have started its review. |
Added preBuild generateGoogleServicesJson task to ensure that the file is generated after a build variant is changed
Update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thank you!
# Conflicts: # core/src/main/java/org/openedx/core/config/FirebaseConfig.kt # default_config/dev/config.yaml # default_config/prod/config.yaml # default_config/stage/config.yaml
2789396
to
358b81d
Compare
358b81d
to
46a5a58
Compare
@farhan-arshad-dev, feedback addressed. |
@volodymyr-chekyrta 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR returns the default Firebase configuration flow with the
google-services.json
file.The manual configuration will be implemented for the Learning site project in a separate module.
OpenEdXApp.kt
generateGoogleServicesJson
function inConfigHelper.groovy
.GCM_SENDER_ID
was replaced withPROJECT_NUMBER
in theFirebaseConfig.kt
file.How to test:
config.yaml
file with the necessary dataNotes:
google-services.json generated by Firebase
google-services.json generated by ConfigHelper