feat: Pre-Login Experience enhancement by integrating webview discovery #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamzaIsrar12
requested changes
Feb 1, 2024
discovery/src/main/java/org/openedx/discovery/presentation/DiscoveryNavigator.kt
Outdated
Show resolved
Hide resolved
discovery/src/main/java/org/openedx/discovery/presentation/WebViewDiscoveryFragment.kt
Outdated
Show resolved
Hide resolved
discovery/src/main/java/org/openedx/discovery/presentation/WebViewDiscoveryFragment.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/org/openedx/auth/presentation/signup/SignUpFragment.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/info/CourseInfoFragment.kt
Outdated
Show resolved
Hide resolved
discovery/src/main/java/org/openedx/discovery/presentation/WebViewDiscoveryViewModel.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/info/CourseInfoViewModel.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/info/CourseInfoViewModel.kt
Show resolved
Hide resolved
HamzaIsrar12
requested changes
Feb 2, 2024
auth/src/main/java/org/openedx/auth/presentation/logistration/LogistrationFragment.kt
Show resolved
Hide resolved
auth/src/main/java/org/openedx/auth/presentation/signup/SignUpFragment.kt
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/info/CourseInfoFragment.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/info/CourseInfoFragment.kt
Outdated
Show resolved
Hide resolved
HamzaIsrar12
previously approved these changes
Feb 4, 2024
k1rill
reviewed
Feb 13, 2024
| requireArguments().apply { | ||
| this.getString(ARG_COURSE_ID, null)?.apply { | ||
| router.navigateToCourseDetail(parentFragmentManager, this) | ||
| requireArguments().run { |
There was a problem hiding this comment.
why we changed apply to run here?
There was a problem hiding this comment.
Apologies for the oversight. Since we are not returning any value, we can proceed with using apply, as we are updating the bundle properties after processing them.
@k1rill thorughs?
k1rill
previously approved these changes
Feb 14, 2024
- Integrate search to align with configured discovery settings. - “Explore All Courses" redirects based on the feature discovery flag. - Auth Panel (SignIn, Register) remains visible during pre-login webview discovery. - Ensure Sign In & Enroll mirror Native Discovery & Market App functionality. - Clear edit text after submit Logistration. - Fix test cases for View Models. LEARNER-9798
farhan-arshad-dev
dismissed stale reviews from k1rill and HamzaIsrar12
via
43a5b9c
farhan-arshad-dev
force-pushed
the
farhan_ar/LEARNER-9798
branch
from
118a3e3 to
43a5b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screen_recording_20240201_162216.webm