feat: theming with config #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewing |
omerhabib26
previously approved these changes
Jan 26, 2024
k1rill
force-pushed
the
feature/theming
branch
from
5121b9d to
211a876
Compare
omerhabib26
previously approved these changes
Jan 26, 2024
k1rill
force-pushed
the
feature/theming
branch
from
b47d912 to
4ce5203
Compare
volodymyr-chekyrta
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration of app theming now is depends of the
PLATFORM_NAMEvalue in theconfig.yamlDefault platform set as
openedx.Colors.ktandLocalShapes.ktmoved to theopenedxfolder, configured assourceSetinside modulecore.Also
LogistrationLogoViewandSignInLogoViewadded to have an ability to customiseComposablefunctions.To make a custom theme you need to duplicate and rename existing
openedexfolder to yours. Now you can change files to be consistent with you app theme.