refactor: Add IDs to elements of landing, login, register, and what's new screens #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhan-arshad-dev
requested review from
omerhabib26,
HamzaIsrar12 and
bilalawan321
HamzaIsrar12
requested changes
Jan 21, 2024
| @@ -276,7 +291,9 @@ private fun SocialLoginView( | |||
| ) { | |||
| if (state.isGoogleAuthEnabled) { | |||
| OpenEdXOutlinedButton( | |||
| modifier = buttonWidth.padding(top = 24.dp), | |||
| modifier = buttonWidth | |||
| .testTag("btn_google_auth") | |||
There was a problem hiding this comment.
Would providing the ID to the Text Field inside the Row container be beneficial for Bilal? Same goes for other Social Buttons as well.
There was a problem hiding this comment.
yes, requested by the Automation team. assign the id to the Text.
auth/src/main/java/org/openedx/auth/presentation/logistration/LogistrationFragment.kt
Show resolved
Hide resolved
auth/src/main/java/org/openedx/auth/presentation/restore/RestorePasswordFragment.kt
Outdated
Show resolved
Hide resolved
…n screen - Title: (Sign In) - Text: (Welcome back! Please authorize to continue.) - Email and Password (Labels and TextFields) - Button: (Forgot password?) - Button (Sign In) - Text: (Or sign in with:) - Buttons: (Sign in with Google, Facebook, Microsoft and Apple) - On Forgot password page (Title, Text, Email label, Email field and Reset password button) fixes: LEARNER-9726
…ster screen - Title: (Sign up) - Text: (Create new account.) - All Input Fields with Labels and notes under the Fields (Full name, public name, email, password) - Add ID and text: (Country or Region of Residence dropdown and its label) - ID to all buttons (Create account, Register with facebook, Microsoft and Apple) - Dropdowns: (Highest education and Gender) - Dropdown values (Country, education and Gender) fixes: LEARNER-9726
- The title under the App logo (Courses and programs from the world's best universities in your pocket) - Text: (What do you want to learn?) - Textfield (Search our 3000+ courses) - Button: (Explore all courses) - Button: Register - Button: Sign in fixes: LEARNER-9726
- Title and Close Button - Next, Previous & Done Buttons - fix crash on whats new screen fixes: LEARNER-9726
farhan-arshad-dev
force-pushed
the
farhan_ar/LEARNER-9726
branch
from
9c2fe15 to
b43d353
Compare
HamzaIsrar12
approved these changes
Jan 22, 2024
|
Hey @farhan-arshad-dev |
volodymyr-chekyrta
approved these changes
Jan 22, 2024
k1rill
approved these changes
Jan 22, 2024
omerhabib26
pushed a commit
to omerhabib26/openedx-app-android
that referenced
this pull request
Jan 22, 2024
… new screens (openedx#189) refactor: add unique ID for all input fields and their titles in login screen - Title: (Sign In) - Text: (Welcome back! Please authorize to continue.) - Email and Password (Labels and TextFields) - Button: (Forgot password?) - Button (Sign In) - Text: (Or sign in with:) - Buttons: (Sign in with Google, Facebook, Microsoft and Apple) - On Forgot password page (Title, Text, Email label, Email field and Reset password button) refactor: add unique ID for all input fields and their titles in Register screen - Title: (Sign up) - Text: (Create new account.) - All Input Fields with Labels and notes under the Fields (Full name, public name, email, password) - Add ID and text: (Country or Region of Residence dropdown and its label) - ID to all buttons (Create account, Register with facebook, Microsoft and Apple) - Dropdowns: (Highest education and Gender) - Dropdown values (Country, education and Gender) refactor: add a Unique ID for Landing Screen - The title under the App logo (Courses and programs from the world's best universities in your pocket) - Text: (What do you want to learn?) - Textfield (Search our 3000+ courses) - Button: (Explore all courses) - Button: Register - Button: Sign in refactor: add a Unique ID for What's new Screen - Title and Close Button - Next, Previous & Done Buttons - fix crash on whats new screen fixes: LEARNER-9726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add IDs to elements of landing, login, register, and what's new screens.
Landing Screen:
Login Screen:
Register Screen:
Whats new screen: