-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: survey content #177
feat: survey content #177
Conversation
I'm starting the review. |
course/src/main/java/org/openedx/course/presentation/unit/html/HtmlUnitFragment.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/unit/html/HtmlUnitFragment.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
course/src/main/java/org/openedx/course/presentation/unit/html/HtmlUnitFragment.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/unit/html/HtmlUnitViewModel.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/unit/html/HtmlUnitViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits only.
Note: The standard practice is to rebase your branch instead of merging changes from others into it. This ensures that the Git graph and the commits on your pull request remain unaffected. 😃
course/src/main/java/org/openedx/course/presentation/unit/html/HtmlUnitFragment.kt
Outdated
Show resolved
Hide resolved
course/src/main/java/org/openedx/course/presentation/unit/html/HtmlUnitFragment.kt
Outdated
Show resolved
Hide resolved
…he onPageStarted function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏎️ ✨
Added ability to view the survey content.
For this purpose I moved all js injections (scripts) to the asset folder.