Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: survey content #177

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

dixidroid
Copy link
Contributor

Added ability to view the survey content.
For this purpose I moved all js injections (scripts) to the asset folder.

@dixidroid dixidroid linked an issue Jan 8, 2024 that may be closed by this pull request
@HamzaIsrar12
Copy link
Contributor

I'm starting the review.

Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some unknown reason, the survey content is not loading now. 🤔

Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits only.

Note: The standard practice is to rebase your branch instead of merging changes from others into it. This ensures that the Git graph and the commits on your pull request remain unaffected. 😃

Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏎️ ✨

@volodymyr-chekyrta volodymyr-chekyrta merged commit d1fc2c7 into openedx:develop Jan 19, 2024
3 checks passed
@dixidroid dixidroid deleted the feat/survey_content branch January 19, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Survey content
3 participants