-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Mark OEP-48 as Approved and OEP-23 as replaced #395
Conversation
Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change @xitij2000 , I agree it's time to mark this as complete. Could you:
- mark OEP-23 as "Replaced"
- add a changelog entry to the bottom of this OEP as well as OEP-23
- post this PR in the #open-edx-proposals channel and wait a week, just to give folks a chance to raise their hand if they disagree
OEP-48 deals with customising branding for MFEs usin an npm package override. This mechanism for branding is now supported across all MFEs, and is also supported by both the configuration repo, and Tutor. As such this PR updates its status from Provisional to Accepted.
298d0cf
to
a55253c
Compare
…ion.rst Co-authored-by: Kyle McCormick <kdmc@pm.me>
a55253c
to
8f08da2
Compare
Sorry for the delay. I've updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Hey @kdmccormick and @arbrandes! Now that this PR is ready to go, would it be possible to move forward with merging it? I'm not sure who has permission to hit the button; please let me know if there's someone else I should ping. |
@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
OEP-48 deals with customising branding for MFEs usin an npm package override.
This mechanism for branding is now supported across all MFEs, and is also
supported by both the configuration repo, and Tutor. As such this PR updates its
status from Provisional to Accepted.