Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Install pip and pip-tools in upgrade script #239

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

Jawayria
Copy link
Contributor

@Jawayria Jawayria commented May 31, 2022

Updated the upgrade target script to check the compatibility of upgraded pip and pip-tools versions.
For reference, look at this openedx/edx-repo-health#271 for new check added in edx-repo-health.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #239 (4e127c5) into master (eef49e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files          29       29           
  Lines        2837     2837           
  Branches      292      292           
=======================================
  Hits         2669     2669           
  Misses        143      143           
  Partials       25       25           
Flag Coverage Δ
unittests 94.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef49e1...4e127c5. Read the comment docs.

Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip.in needs to include common constraints in it.

@Jawayria Jawayria force-pushed the jawayria/fix-upgrade branch from f9c51f7 to 4e127c5 Compare July 29, 2022 09:00
@Jawayria Jawayria merged commit 03254a9 into master Jul 29, 2022
@Jawayria Jawayria deleted the jawayria/fix-upgrade branch July 29, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants