-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add catalog info for backstage #130
chore: add catalog info for backstage #130
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 10 10
Lines 381 381
Branches 28 28
=======================================
Hits 379 379
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of things you can get rid of but then I think this is good to land. I don't need another review if you are dropping those too things I pointed out.
catalog-info.yaml
Outdated
title: "Source Code" | ||
icon: "Code" | ||
annotations: | ||
github.com/project-slug: openedx/i18n-tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this, see the example here for the latest best practice for catalog-info.yaml: https://docs.openedx.org/projects/openedx-proposals/en/latest/processes/oep-0055/decisions/0001-use-backstage-to-support-maintainers.html#references
catalog-info.yaml
Outdated
name: 'i18n-tools' | ||
description: "Tools to help with internationalization and localization of Open edX projects" | ||
links: | ||
- url: "https://github.com/openedx/i18n-tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gets auto linked so you don't need to do it explicitly.
@feanil just to confirm before I update this apiVersion: backstage.io/v1alpha1
kind: Component
metadata:
name: 'i18n-tools'
description: "Tools to help with internationalization and localization of Open edX projects"
spec:
owner: domain-translations
type: 'library'
lifecycle: 'production' is all we need? |
Yep, that looks right to me. |
472ee4b
to
dc14a93
Compare
dc14a93
to
1f1d850
Compare
No description provided.