Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove transifex and hardcoded translations | FC-0012 #728

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Jan 29, 2024

After the Transifex cutover, we expect new MFEs to have atlas exclusively.

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 29, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 29, 2024

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@OmarIthawi OmarIthawi marked this pull request as draft January 29, 2024 16:17
@OmarIthawi OmarIthawi marked this pull request as ready for review February 1, 2024 17:48
@OmarIthawi
Copy link
Member Author

@shadinaif would you mind reviewing this pull request?

@OmarIthawi
Copy link
Member Author

@brian-smith-tcril would you mind checking this PR?

@brian-smith-tcril brian-smith-tcril merged commit af24ba9 into openedx:master Feb 15, 2024
5 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants