Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated frontend-build & frontend-platform major versions #59

Merged

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Apr 23, 2024

Description
Major version upgrades, Updating frontend-build to v14 & frontend-platform to v8 along with respective edx packages

Reference to respective MFEs with the build and platform major version upgrades to be released as minor versions instead of major

@BilalQamar95 BilalQamar95 self-assigned this Apr 23, 2024
@BilalQamar95 BilalQamar95 marked this pull request as ready for review April 24, 2024 12:32
@jsnwesson
Copy link
Contributor

Since the footer and header packages were removed in #61 , I think we can close this PR and make the version bumps to Build/Platform when needed.

@jsnwesson jsnwesson closed this May 10, 2024
@BilalQamar95
Copy link
Contributor Author

BilalQamar95 commented May 15, 2024

@jsnwesson this was less about header & footer packages and more about frontend-build/platform major version upgrades which upgrades jest to v29. Since Jest v29 upgrade is being done across all MFEs, Build/Platform versions upgrades were needed to unblock its consumers for the jest upgrade. I'm re-opening the PR, hopefully I'm not missing anything and you can help get this approved/merged

@BilalQamar95 BilalQamar95 reopened this May 15, 2024
@jsnwesson
Copy link
Contributor

Apologies for prematurely closing this PR! I'll be looking at this tomorrow to make sure it works as expected. If you would be able to update the package.jsons for each example app to use the new version of frontend-build (and running them locally to make sure the plugins still appear), that'll add confidence for me that this PR won't have any negative impact on the MFEs using plugins.

@BilalQamar95
Copy link
Contributor Author

Apologies for prematurely closing this PR! I'll be looking at this tomorrow to make sure it works as expected. If you would be able to update the package.jsons for each example app to use the new version of frontend-build (and running them locally to make sure the plugins still appear), that'll add confidence for me that this PR won't have any negative impact on the MFEs using plugins.

Sure, I have updated frontend-build along with header/footer for example apps & ran them without any issues

@jsnwesson jsnwesson merged commit b0649d4 into openedx:master May 16, 2024
5 checks passed
@openedx-semantic-release-bot

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants